Pic 18F452 / push button

I went to company support divition and they told me this kind of pickit 2 clone have some issue with OSCAL value,if it change it to unsupported or out of range value, your chip , in this programmer is doomed , you should get another chip, spacially in 12Fxx series.

They gave me another simpler programmer which is cloned from banner8(German made programmer) to solve the OSCAL problem , it is fine but it is not PICKIT 2.

In C it is best practice to use prototypes. Generally, you want to declare your function prototypes in a header file. For your code perhaps call the header file BCD.h and create it in the 'Header Files' section of MPLAB. The header file code should look something like the following:

#ifndef BCD_H
#define BCD_H

uint8_t updateBCD(uint8_t);

#endif 

then add the following line to main.c

#include "BCD.h"

Explanation: In your code when the compiler encounters the line "digit = updateBCD(digit)" the compiler does not yet know about the function updateBCD. This is the implicit declaration. Moving the declaration of updateBCD to before main helps in that the complier knows about updateBCD before it encounters "digit = updateBCD".

From a programming stand point this is still somewhat undesirable because then you have to worry about in which order to declare your functions. Aside from being annoying to the coder, it can also make the code more difficult for others to read and interpret. Using functions prototypes in header files alleviates these issues.