Is it safe to not implement HttpPostActionInterface

magento2

Is it safe to not implement HttpPostActionInterface ?

From:

class NewAction extends SubscriberController implements HttpPostActionInterface

To:

class NewAction extends SubscriberController

My goal on removing the implement HttpPostActionInterface was to prevent the page on displaying the 404 page if no post was sent. Our requirement was only to display a blank page when user manually load the link.

Or if you have other option on displaying blank page instead displaying 404 not found content.

Other Classes connected/extended that might help:

SubscriberController

abstract class Subscriber extends \Magento\Framework\App\Action\Action

\Magento\Framework\App\Action\Action

abstract class Action extends AbstractAction

AbstractAction

abstract class AbstractAction implements \Magento\Framework\App\ActionInterface

Best Answer

Your Controller Must Implement POST or GET Action Interface Class Other wise it will give you 404 No Found to your request

if your controller SubscriberController is implement any of ActionInterface its okay you don't need to implement that again

Update

The Class \Magento\Framework\App\Action\Action can be used but it is depreciated after Magneto 2.4 so it's a good practice to implement PostActionInterface

Related Solutions

Magento – Magento 2: How to override newsletter Subscriber model

Finally i have resolve my issue . Only Need to override Subscriber. I am posting my entire code. may be it will helpful to someone. di.xml

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <preference for="Magento\Newsletter\Model\Subscriber" type="Navin\Subscribe\Model\Subscriber" />
</config>

Subscriber.php Model Files

namespace Navin\Subscribe\Model;

class Subscriber extends \Magento\Newsletter\Model\Subscriber {

    /**
     * Initialize resource model
     *
     * @return void
     */

    public function subscribe($email, $subscriber_name = '', $subscriber_date_of_birth = '', $subscriber_country_code = '') {

        $this->loadByEmail($email);

        if (!$this->getId()) {
            $this->setSubscriberConfirmCode($this->randomSequence());
        }

        $isConfirmNeed = $this->_scopeConfig->getValue(
                        self::XML_PATH_CONFIRMATION_FLAG, \Magento\Store\Model\ScopeInterface::SCOPE_STORE
                ) == 1 ? true : false;
        $isOwnSubscribes = false;

        $isSubscribeOwnEmail = $this->_customerSession->isLoggedIn() && $this->_customerSession->getCustomerDataObject()->getEmail() == $email;

        if (!$this->getId() || $this->getStatus() == self::STATUS_UNSUBSCRIBED || $this->getStatus() == self::STATUS_NOT_ACTIVE
        ) {
            if ($isConfirmNeed === true) {
                // if user subscribes own login email - confirmation is not needed
                $isOwnSubscribes = $isSubscribeOwnEmail;
                if ($isOwnSubscribes == true) {
                    $this->setStatus(self::STATUS_SUBSCRIBED);
                } else {
                    $this->setStatus(self::STATUS_NOT_ACTIVE);
                }
            } else {
                $this->setStatus(self::STATUS_SUBSCRIBED);
            }

            $this->setSubscriberEmail($_POST['email']);

        }

        if(!empty($_POST['subscriber_name']) ){
                $this->setSubscriberName($_POST['subscriber_name']); //subscriber_name
                $this->setSubscriberDateofbirth($_POST['subscriber_dateofbirth']); //date of birth
                $this->setSubscriberCountrycode($_POST['subscriber_countrycode']); //country code
        }

        if ($isSubscribeOwnEmail) {
            try {
                $customer = $this->customerRepository->getById($this->_customerSession->getCustomerId());
                $this->setStoreId($customer->getStoreId());
                $this->setCustomerId($customer->getId());
            } catch (NoSuchEntityException $e) {
                $this->setStoreId($this->_storeManager->getStore()->getId());
                $this->setCustomerId(0);
            }
        } else {
            $this->setStoreId($this->_storeManager->getStore()->getId());
            $this->setCustomerId(0);
        }

        $this->setStatusChanged(true);

        try {
            $this->save();
            if ($isConfirmNeed === true && $isOwnSubscribes === false
            ) {
                $this->sendConfirmationRequestEmail();
            } else {
                $this->sendConfirmationSuccessEmail();
            }
            return $this->getStatus();
        } catch (\Exception $e) {
            throw new \Exception($e->getMessage());
        }
    }

}

Magento – Magento 2 get availabe stock of product

You have to use the StockRegistryInterface, Also you have to see the extended class and pass all needed parameters to the parent constructor, in your class you extended this class

=>\Magento\Catalog\Block\Product\ListProduct

So you have to pass his parameters,

Try this code.

 <?php
namespace Tm\Stockinfo\Block\Product;

class Stockqty extends \Magento\Catalog\Block\Product\ListProduct
{

    protected $_stockRegistry;

    public function __construct(
        \Magento\Catalog\Block\Product\Context $context,
        \Magento\Framework\Data\Helper\PostHelper $postDataHelper,
        \Magento\Catalog\Model\Layer\Resolver $layerResolver,
        \Magento\Catalog\Api\CategoryRepositoryInterface $categoryRepository,
        \Magento\Framework\Url\Helper\Data $urlHelper,
        \Magento\CatalogInventory\Api\StockRegistryInterface $stockRegistry,
        array $data = [])
    {
            parent::__construct(
                $context,
                $postDataHelper,
                $layerResolver,
                $categoryRepository,
                $urlHelper,
                $data
                );
        $this->_stockRegistry = $stockRegistry;
    }

    public function getStockQty(
        $product)
    {
        $stockitem = $this->_stockRegistry->getStockItem($product->getId(),
            $product->getStore()
                ->getWebsiteId());
        $qtyStock = $stockitem->getData("qty");
        return $qtyStock;
    }
}

Please note that this code working on Magento 2.2.3, So you need to check the parent class in your version

Best Answer

Related Solutions

Magento – Magento 2: How to override newsletter Subscriber model

Magento – Magento 2 get availabe stock of product

Related Topic