CE 1.9.2 – Custom sales_order_save_after Observer Fires Twice

ce-1.9.2.0event-observermodule

This has been driving me crazy for the last few hours now. I created a module to test sending Suppliers a custom email only once the order has been paid for (Order status changes to Processing). I thought everything was working well: emails were been sent, the correct data was coming through the emails … until I realised that the emails were being sent twice.

To troubleshoot this, I skipped the email function, and instead wrote the word hello to a custom log file. And indeed hello was written twice. Here are some excerpts from my code for my custom module which is currently observing the sales_order_save_after event.

inside config.xml

<events>
    <sales_order_save_after>
        <observers>
            <test_suppliernotification>
                <type>singleton</type>
                <class>test_mod/observer</class>
                <method>notifySupplier</method>
            </test_suppliernotification>
        </observers>
    </sales_order_save_after>
</events>

inside app/code/local/Test/SupplierNotification/Model/Observer.php

class Test_SupplierNotification_Model_Observer
{
    public function notifySupplier(Varien_Event_Observer $observer) {
        $order = $observer->getEvent()->getOrder();
        $stateProcessing = Mage_Sales_Model_Order::STATE_PROCESSING;

        if($order->getState() == $stateProcessing && $order->getOrigData('state') != $stateProcessing) {
            Mage::log("hello", null, 'test_suppliernotification.log');
            return true;
        }
    }
}

output of var/log/test_suppliernotification.log

2015-10-02T01:17:49+00:00 DEBUG (7): hello
2015-10-02T01:17:49+00:00 DEBUG (7): hello

I cannot figure this one out! Has something like this happen to any of you, and if so, how did you solve it? I'm not sure what additional info you may require, so please let me know if you need to see any additional code. I'd really appreciate any assistance in this regard.

EDIT
Forgot to mention that for the particular order that I had tested, the Order status moved from Pending -> Pending Payment -> Processing.

Best Answer

I donot know why this is happing but you can prevent using registry variable (Mage::registry('VARIEABLE')).

<?php
class Test_SupplierNotification_Model_Observer
{
    public function notifySupplier(Varien_Event_Observer $observer) {

  /*check registry variable and 

  on first time Mage::registry('prevent_observer') does not save value 
  So, it will execuate only on first time 
  */
  if(!Mage::registry('prevent_observer')):
      $order = $observer->getEvent()->getOrder();
      $stateProcessing = Mage_Sales_Model_Order::STATE_PROCESSING;
   // Assign value to registry variable
  Mage::register('prevent_observer',true);

      if($order->getState() == $stateProcessing && $order->getOrigData('state') != $stateProcessing) {
          Mage::log("hello", null, 'test_suppliernotification.log');
          return true;
      }

      endif;
    }
}

Related Solutions

Magento – Right magento observer for order paid

I use as follows:

1 - app/code/loca/Packagename/Modulename/etc/config.xml

<config>
<global>
    <models>
        <sales>
            <rewrite>
                <order>Packagename_Modulename_Model_Rewrite_Order</order>
            </rewrite>
        </sales>
        <sales_resource>
            <rewrite>
                <quote>Packagename_Modulename_Model_Rewrite_Resource_Sales_Quote</quote>
            </rewrite>
        </sales_resource>
        <modelrewrite>
            <class>Packagename_Modulename_Model_Rewrite</class>
        </modelrewrite>
    </models>        
    <events>
        <packagename_modulename_order_status_change>
            <observers>
                <packagename_modulename_model_rewrite>
                    <type>singleton</type>
                    <class>modelrewrite/observer</class>
                    <method>changeStateOrder</method>
                </packagename_modulename_model_rewrite>
            </observers>
        </packagename_modulename_order_status_change>
    </events>        
     <resources>
        <modulename_setup>
            <setup>
                <module>Packagename_Modulename</module>
                 <class>Mage_Sales_Model_Resource_Setup</class>
            </setup>
            <connection>
            <use>core_setup</use>
            </connection>
        </modulename_setup>
    </resources>        
</global>
  <crontab>
    <!-- here I am listing only major routines  -->
    <jobs>        
        <Packagename_Modulename_Model_Rewrite_SendOrderToERP>
            <schedule>
                <cron_expr>12 * * * *</cron_expr>
            </schedule>
            <run>
                <model>modelrewrite/observer::runSendOrderToERP</model>
            </run>
        </Packagename_Modulename_Model_Rewrite_SendOrderToERP>            
        <Packagename_Modulename_Model_Rewrite_ReceiveERPStatusOrder>
            <schedule>
                <cron_expr>*/5 * * * *</cron_expr>
            </schedule>
            <run>
                <model>modelrewrite/observer::runReceiveERPStatusOrder</model>
            </run>
        </Packagename_Modulename_Model_Rewrite_ReceiveERPStatusOrder>            
    </jobs>        
</crontab>

2 - app/code/loca/Packagename/Modulename/Model/Rewrite/Order.php

class Packagename_Modulename_Model_Rewrite_Order extends Mage_Sales_Model_Order{

public function _setState($state, $status = false, $comment = '', $isCustomerNotified = null, $shouldProtectState = false){
    // attempt to set the specified state
    // tenta definir o status especificado
    if ($shouldProtectState) {
        if ($this->isStateProtected($state)) {
            Mage::throwException(
                Mage::helper('sales')->__('The Order State "%s" must not be set manually.', $state)
            );
        }
    }
    $this->setData('state', $state);

    // add status history
    if ($status) {
        if ($status === true) {
            $status = $this->getConfig()->getStateDefaultStatus($state);
        }
        $this->setStatus($status);
        $history = $this->addStatusHistoryComment($comment, false); // no sense to set $status again
        $history->setIsCustomerNotified($isCustomerNotified); // for backwards compatibility
    }

    Mage::dispatchEvent('packagename_modulename_order_status_change', array('order' => $this, 'state' => $state, 'status' => $status, 'comment' => $comment, 'isCustomerNotified' => $isCustomerNotified));              
    Mage::log("Packagename_Modulename_Model_Rewrite_Order Changing order to STATE ".$state." STATUS ".$status);
    return $this;
}

}

3 - app/code/loca/Packagename/Modulename/Model/Rewrite/Observer.php

class Packagename_modulename_Model_Rewrite_Observer{

public function implementOrderStatus($event){
    $order = $event->getOrder();
    $state = $event->getState();
    $status = $event->getStatus();
    return $this;
} 

public function changeStateOrder($observer){
    Mage::log('changeStateOrder');
    $order = $observer->getEvent()->getOrder();       

    if($order->getStatus() == "processing_paid"){
        $this->autoInvoicing($order);
    }
    else if($order->getStatus() == "processing_shipped"){
        $this->autoShipment($order);
    }

    // use your necessary ifs
    $this->sendTransactionalEmail($order);

    return $this;
}


public function autoShipment(Mage_Sales_Model_Order $order){ 
    //...    
}

public function autoInvoicing(Mage_Sales_Model_Order $order){ 
    //...    
    //return $this;
}

public function sendTransactionalEmail(Mage_Sales_Model_Order $order){

    switch ($order->getStatus()) {            
        case "processing":
            $templateId = 1;                        
            break;
        case "pending_payment":
            $templateId = 0;                        
            break;            
    //...                    
        default:
            $templateId = 0;
            break;
    }        

//...
}


public function runSendOrderToERP($schedule){
     //...
}


public function runReceiveERPStatusOrder($schedule){        
    //...
}

//And much more another methods can be used after change state / status order: refund, calcel, etc

Magento 1.7 Change Order Status After PayPal Express – How to Update Order Status

Have a go with the sales_order_place_after event, this is fired after the call to $this->_placePayment(); in Mage_Sales_Model_Order::place() so it should be after any other status changes have happened.

Best Answer

Related Solutions

Magento – Right magento observer for order paid

Magento 1.7 Change Order Status After PayPal Express – How to Update Order Status

Related Topic