bugcoupondiscountshopping
I upgraded recently from 1.7 to 1.9.0.1 and I am wondering if this is a bug or if I just missed some new configuration, I am not using tax classes btw.
When creating a shopping cart price rule, (e.g. coupon, sub total equals or greater than 100, fixed discount for the whole cart 15), the discount applied on the subtotal diminishes with every additional product added if and only when setting "Stop further rules processing" to "Yes".
I tested this on a vanilla installation.
I solved it myself!
Strangely, I had to put the current currency sign before amount. We are using INR (Rs.). So I needed to use "Rs. 2000" instead of "2000". So my condition is changed from (emphasis the difference)
- If ALL of these conditions are TRUE :
- Subtotal equals or greater than 2000
to
- If ALL of these conditions are TRUE :
- Subtotal equals or greater than Rs. 2000
After that change, I could apply the coupon successfully even with one step checkout:
I think this could be because the _calculator is effectively stored as a singleton within the Mage_SalesRule_Model_Quote_Discount class, meaning that the second item to be processed will hit $this->_stopFurtherRules == true and bail.
My thought process is to store the ID of the $rule which is OK to be processed, allowing further items to process only this rule.
As per CE1.9.0.1 and EE1.14.0.1
Mage_SalesRule_Model_Validator line 316
- if ($this->_stopFurtherRules) {
+ if ($this->_stopFurtherRules !== false && $rule->getId() != $this->_stopFurtherRules) {
Mage_SalesRule_Model_Validator line 514
- $this->_stopFurtherRules = true;
+ $this->_stopFurtherRules = $rule->getId();
This is my proposed solution, I would be interested to hear reasons why this is a terrible idea!
Best Answer
This is a bug which has been reported and was introduced in 1.9. There is flawed logic which means when using 'Stop Further Rules Processing' only the first product in the cart has the cart rule applied. Magento have said We are checking the issue as there are more reports related to it but I suspect a fix may be some time coming.
In the mean time we have created a module to fix the issue here.