Magento – Empty attributes displaying as No – I’ve rewritten the block and it still displays No

magento-1.9product-attribute

I have rewritten the Mage_Catalog_Block_Product_View_Attributes block with the following to not display N/A or No attributes. However, some blank attributes are still displaying as No on the front end. I want to be able to keep Yes/No type attributes on the front end so I can't just apply an if statement for "No". Is there somewhere else Magento could be changing an empty attribute to No?

EDIT: After further research it appears this is happening on dropdown attributes.

public function getAdditionalData(array $excludeAttr = array())
{
    $data = array();
    $product = $this->getProduct();
    $attributes = $product->getAttributes();
    foreach ($attributes as $attribute) {
//            if ($attribute->getIsVisibleOnFront() && $attribute->getIsUserDefined() && !in_array($attribute->getAttributeCode(), $excludeAttr)) {
        if ($attribute->getIsVisibleOnFront() && !in_array($attribute->getAttributeCode(), $excludeAttr)) {
            $value = $attribute->getFrontend()->getValue($product);

            if (!$product->hasData($attribute->getAttributeCode())) {
                $value = Mage::helper('catalog')->__('N/A');
            } elseif ((string)$value == '') {
                // $value = Mage::helper('catalog')->__('No');
            } elseif ($attribute->getFrontendInput() == 'price' && is_string($value)) {
                $value = Mage::app()->getStore()->convertPrice($value, true);
            }
            if($value === 'N/A' || $value === ''){
                //do nothing makes sure N/A and empty attributes don't show up on product view page
            }
            elseif(is_string($value) && strlen($value)) {
                $data[$attribute->getAttributeCode()] = array(
                    'label' => $attribute->getStoreLabel(),
                    'value' => $value,
                    'code'  => $attribute->getAttributeCode()
                );
            }


        }
    }
    return $data;
}

Best Answer

Hide the empty attributes by just edit the template file named as app/design/frontend/[mypackage]/[mytheme]/template/catalog/product/view/attributes.phtml

In your code, find following lines:

<?php foreach ($_additional as $_data): ?>
     <tr>
         <th class="label"><?php echo $this->htmlEscape($this->__($_data['label'])) ?></th>
         <td class="data"><?php echo $_helper->productAttribute($_product, $_data['value'], $_data['code']) ?></td>
     </tr>

Replace this:

<?php foreach ($_additional as $_data): ?>
   <?php if ((string)$_data['value'] != '' and $_data['value'] != 'N/A'): ?>
   <tr>
        <th class="label"><?php echo $this->htmlEscape($this->__($_data['label'])) ?></th>
        <td class="data"><?php echo $_helper->productAttribute($_product, $_data['value'], $_data['code']) ?></td>
    </tr>
  <?php endif; ?>
  <?php endforeach; ?>

Related Solutions

Magento – create new product attribute returns fault code 104 (Incorrect attribute type)

A little extra debugging should get you where you need to be.

First, your error string/code, (104 (Incorrect attribute type)), can be traced to the following API exception.

#File: app/code/core/Mage/Catalog/etc/api.xml
<invalid_frontend_input>
    <code>104</code>
    <message>Incorrect attribute type.</message>
</invalid_frontend_input>

This means the API code used to trigger the exception will look something like this

$this->_fault('invalid_frontend_input');

That is, the name of the configured node in api.xml is used as a shortcut for the exception. As you hinted in your question, this can be traced to the following bit of PHP code

#File: app/code/core/Mage/Catalog/Model/Product/Attribute/Api.php
//validate frontend_input
$allowedTypes = array();
foreach ($this->types() as $type) {
    $allowedTypes[] = $type['value'];
}
if (!in_array($data['frontend_input'], $allowedTypes)) {
    $this->_fault('invalid_frontend_input');
}

Here Magento's API code is checking the method's data paramater for a frontend_input key. The "frontend input" is the type of UI form Magento will generate for editing this attribute's value in the Magento admin. Based on your soap request, it looks like your code failed to submit a value for frontend_input.

<!-- no frontend input -->
<data xsi:type="ns1:catalogProductAttributeEntityToCreate">
    <attribute_code xsi:type="xsd:string">testattribute</attribute_code>
    <scope xsi:type="xsd:string">store</scope>
    <default_value xsi:type="xsd:string"/>
    <frontend_label xsi:type="ns1:catalogProductAttributeFrontendLabelEntity">
        <store_id xsi:type="enc:string">0</store_id>
        <label xsi:type="enc:string">Test label</label>
    </frontend_label>
</data>

That's why Magento raised an exception. You need your SOAP calling code to submit a value that is both not blank and matches the one of the values returned by the $this->types() method call (which populates the $allowedTypes array). If you trace the call to types, you'll see

public function types()
{
    return Mage::getModel('catalog/product_attribute_source_inputtype')->toOptionArray();
}

Which, in turn, leads you to the catalog/product_attribute_source_inputtype model (Mage_Catalog_Model_Product_Attribute_Source_Inputtype), etc. Probably the quickest way to get a list of values here is to write some quick one off code to peek at the results of the toOptionArray call.

In a stock system the following

$options = Mage::getModel('catalog/product_attribute_source_inputtype')->toOptionArray();
var_dump($options);

results in

array (size=8)
  0 => 
    array (size=2)
      'value' => string 'text' (length=4)
      'label' => string 'Text Field' (length=10)
  1 => 
    array (size=2)
      'value' => string 'textarea' (length=8)
      'label' => string 'Text Area' (length=9)
  2 => 
    array (size=2)
      'value' => string 'date' (length=4)
      'label' => string 'Date' (length=4)
  3 => 
    array (size=2)
      'value' => string 'boolean' (length=7)
      'label' => string 'Yes/No' (length=6)
  4 => 
    array (size=2)
      'value' => string 'multiselect' (length=11)
      'label' => string 'Multiple Select' (length=15)
  5 => 
    array (size=2)
      'value' => string 'select' (length=6)
      'label' => string 'Dropdown' (length=8)
  6 => 
    array (size=2)
      'value' => string 'price' (length=5)
      'label' => string 'Price' (length=5)
  7 => 
    array (size=2)
      'value' => string 'media_image' (length=11)
      'label' => string 'Media Image' (length=11)

Meaning the valid values for frontend_input are

text
textarea
date
boolean
multiselect
select
price
media_image

If you're curious how Magento chooses these values, checkout the aforementioned toOptionArray in

app/code/core/Mage/Catalog/Model/Product/Attribute/Source/Inputtype.php

and its parent class Mage_Eav_Model_Adminhtml_System_Config_Source_Inputtype

app/code/core/Mage/Eav/Model/Adminhtml/System/Config/Source/Inputtype.php

Magento 1.9 – List Attribute Names and Values for a Group

Managed to get the desired output with the following:

<?php 
$setId = $_product->getAttributeSetId(); // Attribute set Id
$groups = Mage::getModel('eav/entity_attribute_group')
    ->getResourceCollection()
    ->setAttributeSetFilter($setId)
    ->setSortOrder()
    ->load();

$attributeCodes = array();
foreach ($groups as $group) {
    if($group->getAttributeGroupName() == 'Specification'){ // set name
    //$groupName          = $group->getAttributeGroupName();
    //$groupId            = $group->getAttributeGroupId();

    $attributes = Mage::getResourceModel('catalog/product_attribute_collection')
        ->setAttributeGroupFilter($group->getId())
        ->addVisibleFilter()
        ->checkConfigurableProducts()
        ->load();
        if ($attributes->getSize() > 0) {
            foreach ($attributes->getItems() as $attribute) {
                /* @var $child Mage_Eav_Model_Entity_Attribute */
                $attributeCodes[] = array('code' => $attribute->getAttributeCode(), 'type' => $attribute->getBackendType(), 'label' => $attribute->getFrontendLabel());  
                //Mage::Log($attribute->debug());

            }
        } 
    }
}

echo '<ul class="check-list attribute-list">';

foreach ($attributeCodes as $attributeCode) {
    $attrValue =  $_product->getData($attributeCode['code']);
    if(isset($attrValue)){
        echo '<li><strong>'. $attributeCode['label'] .': </strong>'. $attrValue .'</li>';
    } // if
} // foreach

echo '</ul>';
?>

Best Answer

Related Solutions

Magento – create new product attribute returns fault code 104 (Incorrect attribute type)

Magento 1.9 – List Attribute Names and Values for a Group

Related Topic