Magento 2 – Failing the Dependencies Check

It might be good to have same instances as dependencies in some edge cases, but your case is not that edge case scenario. If you have more than one instance of the same kind of dependency, it means you probably need to refactor (use factory or object pool).

I think the best option in your case is to use object pool and NOT to have uploaders passed in directly via di.xml.

Why?

1. As it is visible, you have to configure your uploaders correctly before you pass them into the constructor. If I would instantiate your class directly, it is incredibly easy to make a mistake wich class is responsible for images, and which one for files.

2. You have too much configuration in di.xml itself. It makes sense to introduce a configuration model, that will let you specify allowed file types, per uploader. Imagine adding SVG file type, and it requires you to modify di.xml and re-compile di dependencies, that should not be the case, as it is not business logic change, it is just configuration. Di container is for business logic configuration.

3. When you use DI configuration array argument, it is impossible to remove existing file types.

4. Imagine you will need to add document uploader, that will have a restriction on doc, pdf, rtf? It rings a bell right away that just adding the third dependency is not a good option.

What's a better approach?

1. Create a configuration object that will allow you to specify uploader type per field type that need it.

   interface UploadConfigurationInterface
   {
       public function getTmpDirectory($uploaderType);
       public function getSaveDirectory($uploaderType);
       public function getAllowedFileExtensions($uploaderType);
   }
   

2. Then use it in your uploader pool together with auto-generated uploader factory.

   class UploaderPool
   {
       /** @var UploadConfigurationInterface */
       private $uploaderConfiguration;
       /** @var \Sample\News\Model\UploaderFactory */
       private $uploaderFactory;
       /** @var \Sample\News\Model\Uploader[] */
       private $uploaders;
   
       public function getUploader($uploaderType)
       {
           if (isset($this->uploaders[$uploderType])){
               $this->uploaders[$uploderType] = $this->uploaderFactory->create([
                   'baseTmpPath' => $this->uploaderConfiguration->getTmpDirectory($uploaderType),
                   'basePath' => $this->uploaderConfiguration->getSaveDirectory($uploaderType),
                   'allowedExtensions' => $this->uploaderConfiguration->getAllowedFileExtensions($uploaderType)
               ]);
           }
   
           return $this->uploaders[$uploderType];
       }
   }
   

Even better?

The best one would be to refactor your uploader to use a configuration retrieval per field type to know which types will be uploaded to which directory and which file extension restrictions should be applied. Then you don't need object pool to manage it and your uploader will be independent of configuration logic.

Just for the record - probably will help somebody - I had the same issue installing Magento 2.1.8 and, changing the owner of those 4 folders/directories to the user apache runs, made it pass the File Permissions Check right away.

This is in CentOS, "sudo" makes it run as root, so adapt as needed:

sudo chown -R apache:apache /path/to/magento/var/  
sudo chown -R apache:apache /path/to/magento/pub/media/  
sudo chown -R apache:apache /path/to/magento/pub/static/  
sudo chown -R apache:apache /path/to/magento/app/etc/

I've been trying everything I found, from devdocs permissions guide to chmod 777 (775, 755, 700, ...), selinux disable, nothing worked until I tried the above. Changing the owner of those folders to apache user.