Magento – Get plain value from custom variable in php with objectManager

custom-variablemagento2object-managerPHP

I want to get a plain value from custom variable (defined on admin) in php with objectManager.

storeID is in $order->getStore()->getId()

Custom Variable Code is 'mycustomvar'

why does following code not work?

    $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
    $variables = $objectManager->create('Magento\Variable\Model\Variable');
    if ($var = $variables->getResource()->getVariableByCode('mycustomvar', true, $order->getStore()->getId())) {
        $value = 'defined';
//      $value = $variables->getData('plain_value');
    } else {
        $value = 'undefined';
    }

It looks like $var contains the array with the values of mycustomvar, but I'm not sure.

How can I pass $var to getData('plain_value')? Or is there a better way to get 'plain_value'?

Classes I was looking into are

Magento\Variable\Model\Variable

Magento\Variable\Model\ResourceModel\Variable

PS I understood objectManager is not the preferred way, but I need to get this working here

PPS Magento 2.1

Best Answer

Class Magento\Variable\Model\Variable offers everything - such as setStoreId(StoreId), which needs to be set case by case for my application. There is no need to dig into Magento\Variable\Model\ResourceModel\Variable.

The following code is working now. Replace myStoreID and mycustomvar with your needs. Remove code line with setStoreId(StoreId), if you need access to mycustomvar in the current store.

    $objectManager = \Magento\Framework\App\ObjectManager::getInstance();
    $variables = $objectManager->create('Magento\Variable\Model\Variable');
    $variables->setStoreId(myStoreID);

    $value = $variables->loadByCode('mycustomvar')->getPlainValue();

Thanks to Vikas comments, it helped me find the solution.

Related Solutions

Magento 1.9 – Using Custom Variable Plain Value in Email Templates

It is but it'll require some coding.

In a nutshell this is how an email is sent

$template  = Mage::getModel('core/email_template')->loadDefault('[email identifier]');                                  

$template->send('email@domain.com','John Doe', array(
   'myvar' => 'foo',
   'myvar2' => 'bar',
));

now we can access the variables using {{var myvar}} and {{var myvar2}}

So to inject your values you'll need to make modifications to the array with variables injected into the send method.

It depends on what email you want to change

Magento 2 – Best Practices for Dynamically Instantiating Classes with Arguments

No, it's not a good practice to use the object manager.
Use a factory instead.
To get an instance of \Foo\Bar\My\Class you will need to use an instance of \Foo\Bar\My\ClassFactory that will be automatically generated.

I assume that the code you listed in the question is part of a class.
you should have in your class this:

protected $fooBarFactory;
public function __construct(
    ....
    \Foo\Bar\My\ClassFactory $fooBarFactory,
    ....
) {
   .... 
   $this->fooBarFactory = $fooBarFactory;
    ....
}

Then you can instantiate your \Foo\Bar\My\Class like this:

$processorInstance = $this->fooBarFactory->create([
    'model' => $model,
    'config' => $config,
]);

The createmethod takes as parameter an array, and the keys in this array must match the constructor argument names in the class you are instantiating.
Your class accepts 2 parameters in the constructor called $model and $config hence the array keys model and config.
[EDIT]
In case your class acts as a factory you can use ObjectManager.
I think you should move the code that actually instantiates $source in a separate factory (that's not autogenerated) and you are allowed there to use the OM.
And you can inject that general factory in your class and have something like this

$processorInstance = $this->customProcessorFactory->create(
    $source, 
    [
        'model' => $model,
        'config' => $config,
    ]
);

Best Answer

Related Solutions

Magento 1.9 – Using Custom Variable Plain Value in Email Templates

Magento 2 – Best Practices for Dynamically Instantiating Classes with Arguments

Related Topic