My suggestion would be to put an observer on the sales_quote_collect_totals_before
event which is fired in the Mage_Sales_Model_Quote::collectTotals
method before it starts the total collection process. Then from inside this observer method, iterate the quote items and change the tax class on the (already loaded) product object you can retrieve from the quote item.
After you set the information on the product object, whatever you do, DO NOT try and save it to the database. Having the tax class set as needed on the product object in memory will be good enough to have the collect totals logic found in Mage_Tax_Model_Sales_Total_Quote_Tax
pickup which tax class it should base it's calculations on. Saving the product (as you seem to be trying to do in your code sample above) will cause major performance issues, will create race conditions in the calculation process, and is simply not good practice.
The reason that the events you are trying to work with are not enabling you to accomplish what you are trying to accomplish is because they all come after the total calculation, a process which is only be run once prior to saving the quote.
Worth pointing out about the collect totals process is that once run, without doing extra work, you cannot call it again to have it re-calculate based on changes you've made to the quote items. See this tie-bit I've taken from the blog series a colleage of mine recently put together on the collect totals process:
Now that you understand what occurs during the totals collection
process, you may find it convenient or necessary to call it directly
yourself. Before you start feeling too confident with using
collectTotals for your own purposes, though, keep the following rule
in mind:
Products cannot be added to the quote after collectTotals is run!
. . . unless the quote addresses' item caches are cleared.
Nearly every total model's "collect" method relies on fetching the
quote items from the address and looping through them. The first time
getAllItems is run on a quote address, the item collection is actually
cached with a unique key, and it's this cached collection that is
returned on subsequent calls.
If you do happen to have an inkling for really diving into the depths of how the collect totals process works, you can check out the first of the four part series on total collection here for more in-depth reading: Unravelling Magento's collectTotals: Introduction
To summarize, you need to be catching an event which runs before the collect totals process (and before getAllItems is called on the quote addresses) so that changes you make to the items will be used by the total collectors. I've not verified that the suggested sales_quote_collect_totals_before
event runs before any calls to the getAllItems
on the quote address, but I'm almost certain that it will work for what you need. But if not, hopefully I've provided enough context for you to figure out which event you need to catch to make it work.
This sounds like a similar issue I had about a year ago.
The end result was the same as what you have: totals got doubled by qty (qty * qty)
The problem was tracked down to when customer address got added to the order object, it got added twice as delivery address. Thus the order object had 3 addresses:
- 1 - Billing
- 2 - Shipping
- 3 - shipping (duplicate of #2)
I forget why this happened :( (I seem to recall an observer event doing something funky)
The same happened to the quote object (thus cart)
Since totals calculation hang directly off address objects, totals got doubled by qty.
An easy why to test if you are having the same issue, wipe out the sales_flat_order_address table, and enter checkout. Then check the table for address entries for your order. you should have 2 entries in there.
Additionally, since the issue is related to database entries, once the bug was fixed, it looked like the problem remained/was not fixed. It required removing the duplicates from the database for the problem to resolve for existing quote/order objects.
Best Answer
If you want to specify a max quantity, you can set it on the product admin in the inventory tab. The name of the field is Maximum qty allowed in the shopping cart.