Magento 2 – How to Programmatically Check if an Order Exists Without Try-Catch

custommagento-2.1magento2modulesales-order

I am looking at the implementation of \Magento\Sales\Api\OrderRepositoryInterface
on https://github.com/magento/magento2/blob/eacac63d35b97961e3304dc007cd6b78519a93d0/app/code/Magento/Sales/Model/OrderRepository.php

According to the code, the repository will throw NoSuchEntityException if the order does not exist. However, I figure it might be expensive overtime to rely on a try-catch statement if my function gets called quite often.

Is there a command/function that I can use to just get true/false on whether an order exist by given Order ID?

Thank you,

Best Answer

There's some discussion of the overhead of exceptions in PHP here: https://stackoverflow.com/questions/104329/performance-of-try-catch-in-php

But more to the point, the overhead of exceptions (which is very small to begin with) would far and away be dwarfed by the overhead of actually checking whether the order in question exists (loading the ID in question from the database).

If your function gets called 'quite often', it might make sense to consider alternate approaches that would involve less loading from the database (depending on circumstances). Whether or not you catch exceptions isn't going to make a notable difference though.

Use exceptions the way Magento intends. They won't kill you. Be careful about trying to over-optimize the wrong things.

Related Solutions

Magento – Magento 2: How to override newsletter Subscriber model

Finally i have resolve my issue . Only Need to override Subscriber. I am posting my entire code. may be it will helpful to someone. di.xml

<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:ObjectManager/etc/config.xsd">
    <preference for="Magento\Newsletter\Model\Subscriber" type="Navin\Subscribe\Model\Subscriber" />
</config>

Subscriber.php Model Files

namespace Navin\Subscribe\Model;

class Subscriber extends \Magento\Newsletter\Model\Subscriber {

    /**
     * Initialize resource model
     *
     * @return void
     */

    public function subscribe($email, $subscriber_name = '', $subscriber_date_of_birth = '', $subscriber_country_code = '') {

        $this->loadByEmail($email);

        if (!$this->getId()) {
            $this->setSubscriberConfirmCode($this->randomSequence());
        }

        $isConfirmNeed = $this->_scopeConfig->getValue(
                        self::XML_PATH_CONFIRMATION_FLAG, \Magento\Store\Model\ScopeInterface::SCOPE_STORE
                ) == 1 ? true : false;
        $isOwnSubscribes = false;

        $isSubscribeOwnEmail = $this->_customerSession->isLoggedIn() && $this->_customerSession->getCustomerDataObject()->getEmail() == $email;

        if (!$this->getId() || $this->getStatus() == self::STATUS_UNSUBSCRIBED || $this->getStatus() == self::STATUS_NOT_ACTIVE
        ) {
            if ($isConfirmNeed === true) {
                // if user subscribes own login email - confirmation is not needed
                $isOwnSubscribes = $isSubscribeOwnEmail;
                if ($isOwnSubscribes == true) {
                    $this->setStatus(self::STATUS_SUBSCRIBED);
                } else {
                    $this->setStatus(self::STATUS_NOT_ACTIVE);
                }
            } else {
                $this->setStatus(self::STATUS_SUBSCRIBED);
            }

            $this->setSubscriberEmail($_POST['email']);

        }

        if(!empty($_POST['subscriber_name']) ){
                $this->setSubscriberName($_POST['subscriber_name']); //subscriber_name
                $this->setSubscriberDateofbirth($_POST['subscriber_dateofbirth']); //date of birth
                $this->setSubscriberCountrycode($_POST['subscriber_countrycode']); //country code
        }

        if ($isSubscribeOwnEmail) {
            try {
                $customer = $this->customerRepository->getById($this->_customerSession->getCustomerId());
                $this->setStoreId($customer->getStoreId());
                $this->setCustomerId($customer->getId());
            } catch (NoSuchEntityException $e) {
                $this->setStoreId($this->_storeManager->getStore()->getId());
                $this->setCustomerId(0);
            }
        } else {
            $this->setStoreId($this->_storeManager->getStore()->getId());
            $this->setCustomerId(0);
        }

        $this->setStatusChanged(true);

        try {
            $this->save();
            if ($isConfirmNeed === true && $isOwnSubscribes === false
            ) {
                $this->sendConfirmationRequestEmail();
            } else {
                $this->sendConfirmationSuccessEmail();
            }
            return $this->getStatus();
        } catch (\Exception $e) {
            throw new \Exception($e->getMessage());
        }
    }

}

Magento Best Practices – Try/Catch in Templates

In my opinion templates don't have to contain any logic on that point.
If we take your exemple, the best way is to make the try / catch in the block, the template is here only to display data.

Block file

<?php

class Foo extends \Magento\Framework\View\Element\Template
{
    [...]
    public function getName()
    {
        [...]
        try {
            return $product->getSomething()->getName();
        } catch (NoSuchEntityException $ex) {
            $this->logger->critical($ex);

            return false;
        } catch (\Exception $ex)) {
            $this->logger->critical($ex);

            return false;
        }
    }
}

Template file

<?php
/** @var string|false $name */
$name = $block->getName();
?>

[...]
<?php if ($name): ?>
   // logic...
<?php endif; ?>

In your case you can imagine different types of return in your block function and test them on your template to display the right information.

Best Answer

Related Solutions

Magento – Magento 2: How to override newsletter Subscriber model

Magento Best Practices – Try/Catch in Templates

Related Topic