Magento 2 Dependency Injection – Use a Model with a Dynamic Name

dependency-injectionmagento2model

I have a M1 module that I'm looking at porting to M2, and part of one of helpers contains code that looks like this:

public function getModel($code)
{
     return Mage::getSingleton('vendor/package_model_' . $code);
}

Given that Magento 2 uses dependency injection, I know that I can specify that I'd like an instance of \Vendor\Package\Model\Interface, but how can I specify that I'd like a specific model?

I'd like to follow best practice, so if it's possible to avoid doing this directly through the ObjectMananger then that would be ideal, but if that's the only option then that's OK too.

Best Answer

Try to get rid of this shortcut method and use dependency injection to get the actual classes you need where you previously used this.

Related Solutions

Magento – Usage of getSingleton() and getModel()

Yes, getSingleton returns the same instance, so you do not want to use it always, but only if you can live with having the same instance.

Example of when NOT to use a singleton:

$product = Mage::getModel('catalog/product');
$product->setSku("asdfasdf");
$product->setName("First Test Product");
$product->save();

$product = Mage::getModel('catalog/product');
$product->setSku("asdfasdf2");
$product->setName("Second Test Product");
$product->save();

This creates two products. But if you used Singleton, only one product would be created, the second one would overwrite the first one.

Magento 2 – What Triggers the Generation of a Factory

Some interesting code location for how this all works together: https://github.com/magento/magento2/blob/develop/dev/tests/integration/testsuite/Magento/Framework/Code/GeneratorTest.php#L40

With the different types coming mostly from here https://github.com/magento/magento2/tree/develop/lib/internal/Magento/Framework/ObjectManager/Code/Generator but also from here https://github.com/magento/magento2/tree/develop/lib/internal/Magento/Framework/Interception/Code/Generator for the Interception code.

It is all triggered by the autoloader here https://github.com/magento/magento2/blob/develop/lib/internal/Magento/Framework/Code/Generator/Autoloader.php#L32

public function load($className)
{
    if (!class_exists($className)) {
        return Generator::GENERATION_ERROR != $this->_generator->generateClass($className);
    }
    return true;
}

Best Answer

Related Solutions

Magento – Usage of getSingleton() and getModel()

Magento 2 – What Triggers the Generation of a Factory

Related Topic