Magento Coding Standards – Best Practices and Guidelines

codecoding-standardsmagento-1

I recently started working extensively with Magento and Code sniffer, and I would like to know which standards I should follow.

I tried Zend coding standards, but I don't want to use the 80 line limit, and it's not used in the core either.

After that, I tried CS2 standards, but that doesn't work either because of the _ in various functions, and class names, which have an _ in them, and don't have namespaces.

So, is there another standard that the core code complies 100% with ? If not, shouldn't magento have its own coding standards? It has its own stackexchange site, some well defined coding standards would be welcome to be used by extension developers.

Best Answer

You can also try ECG Magento Code Sniffer Coding Standard

Related Solutions

Magento 1 – How to Change Magento Calendar

I have used the spanish calender in magento

Try this codes

jQuery

jQuery(function($){
$.datepicker.regional['es'] = {
    closeText: 'Cerrar',
    prevText: '&#x3c;Ant',
    nextText: 'Sig&#x3e;',
    currentText: 'Hoy',
    monthNames: ['Enero','Febrero','Marzo','Abril','Mayo','Junio',
    'Julio','Agosto','Septiembre','Octubre','Noviembre','Diciembre'],
    monthNamesShort: ['Ene','Feb','Mar','Abr','May','Jun',
    'Jul','Ago','Sep','Oct','Nov','Dic'],
    dayNames: ['Domingo','Lunes','Martes','Mi&eacute;rcoles','Jueves','Viernes','S&aacute;bado'],
    dayNamesShort: ['Dom','Lun','Mar','Mi&eacute;','Juv','Vie','S&aacute;b'],
    dayNamesMin: ['Do','Lu','Ma','Mi','Ju','Vi','S&aacute;'],
    weekHeader: 'Sm',
    dateFormat: 'dd/mm/yy',
    firstDay: 1,
    isRTL: false,
    yearRange:"1950:2050",
    changeYear:true,
    changeMonth:true,
    showMonthAfterYear: false,
    yearSuffix: ''};
$.datepicker.setDefaults($.datepicker.regional['es']);});

In Phtml page i have added this codes

<input type="text" value="01/01/1970"class="input-text validate-age-below-18"   id="datepicker"/></p>                                                                       jQuery(function() {
jQuery.datepicker.setDefaults( jQuery.datepicker.regional[ "" ] );
jQuery( "#datepicker" ).datepicker( jQuery.datepicker.regional[ "es" ] );

});

Hope it will work for you too

Magento ECG Coding Standard – Why Many PHP Functions Are Disallowed

Got an unofficial answer from the ECG team on that:

First of all, the flagged functions are not necessarily disallowed - they should trigger a manual review on usage to ensure legitimate use. It's a review helper tool, not good/bad code scoring tool.

Second, the assumption was it is better to use Magento wrappers (functions/classes) if they exists as they might offer additional functionality or protection.

Third, as for specific calls, base64_decode is used often for malicious injected code, and the rest like parse_str might be vulnerable, especially handling unknown or user provided input - see for example http://php-security.org/2010/05/31/mops-2010-049-php-parse_str-interruption-memory-corruption-vulnerability/

Again, this is flagging it for review not rejecting the code as bad.

Hope it helps.

Best Answer

Related Solutions

Magento 1 – How to Change Magento Calendar

Magento ECG Coding Standard – Why Many PHP Functions Are Disallowed

Related Topic