Magento – Mass delete action in one step not in loop magento 2

magento2massaction

I have custom module with mass delete action feature. how to do mass delete action in one step without loop. Because i got WARNING | Model LSD method delete() detected in loop when i check my module in MEQP 2.

Below is the code used in my module

foreach ($collection as $block) 
{

 $block->delete();

}

After searching the mass action in the MAGE2 core file they too use the same method.
i refered the following path file is vendor/magento/module-cms/Controller/Adminhtml/Block/MassDelete.php

from line no 51 to 53

foreach ($collection as $page) 
{
    $page->delete();
}

i appreciate any one help on this.

Best Answer

try {
    $categoriesIds = ['1','2','3'];
    // use collection factory object of particular model
    $catgoryObj = $this->_objectManager->get('MageArray\Gallery\Model\ResourceModel\Category\CollectionFactory');

    //apply addFieldToFilter  to get particular  record only  from that collection
    $category = $catgoryObj->create()->addFieldToFilter('category_id', array('in' => $categoriesIds));

    //use walk method for mass delete action
    $category->walk('delete'); 
    $this->messageManager->addSuccess(__('A total of %1 record(s) have been deleted.', count($categoriesIds)));

} catch (\Exception $e) {
    $this->messageManager->addError($e->getMessage());
}

Related Solutions

Magento 2 – Mass Action in Grid Redirects to Dashboard

You can add formkey using <update handle="formkey"/> inside your all grid related layout xml files.

ex.module_index_grid.xml code for test,

<?xml version="1.0"?>

<layout xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:View/Layout/etc/layout_generic.xsd">
   <update handle="formkey"/>

   <body> 
         //code for body
   </body>
</layout>

Try using this.

Avoiding Save in a Loop in Magento 2 Mass Action

In that case you have to save() your entities, so you'll definitely have to call that method.

The native core Magento file you linked is not the only one that does that, especially the mass actions action classes.

The only alternative is to add a saveAttribute method to your CRUD resource model based on the one implemented in app/code/Magento/Sales/Model/ResourceModel/Attribute.php :

public function saveAttribute(AbstractModel $object, $attribute)
{
    if ($attribute instanceof AbstractAttribute) {
        $attributes = $attribute->getAttributeCode();
    } elseif (is_string($attribute)) {
        $attributes = [$attribute];
    } else {
        $attributes = $attribute;
    }
    if (is_array($attributes) && !empty($attributes)) {
        $this->getConnection()->beginTransaction();
        $data = array_intersect_key($object->getData(), array_flip($attributes));
        try {
            $this->_beforeSaveAttribute($object, $attributes);
            if ($object->getId() && !empty($data)) {
                $this->getConnection()->update(
                    $object->getResource()->getMainTable(),
                    $data,
                    [$object->getResource()->getIdFieldName() . '= ?' => (int)$object->getId()]
                );
                $object->addData($data);
            }
            $this->_afterSaveAttribute($object, $attributes);
            $this->getConnection()->commit();
        } catch (\Exception $e) {
            $this->getConnection()->rollBack();
            throw $e;
        }
    }
    return $this;
}

This way, instead of calling the following:

$this->authorRepository->save($author);

You should be able to do something like this:

$author->getResource()->saveAttribute($author, array_keys($authorData));

As stated in the comments, you'll have to modify that method a bit if you don't need to check the AbstractAttribute instance to match your needs

Best Answer

Related Solutions

Magento 2 – Mass Action in Grid Redirects to Dashboard

Avoiding Save in a Loop in Magento 2 Mass Action

Related Topic