Magento – Modifying the redirect after editing a product in the cart

cartmagento-1.9magento-ceredirect

I have a problem modifying a redirect in magento CE 1.9.2.

Let's say a customer has a configurable product in the cart, and would like to edit that product (ie. changing color or size or something).

After changing the options and clicking the 'update cart' button I want the customer to stay on the same page (ie. the edit product page). However magento always redirect back to the cart page.

I think I've found source of the problem, in CartController.php from the Checkout module:

/**
 * Update product configuration for a cart item
 */
public function updateItemOptionsAction()
{
    $cart   = $this->_getCart();
    $id = (int) $this->getRequest()->getParam('id');
    $params = $this->getRequest()->getParams();

    if (!isset($params['options'])) {
        $params['options'] = array();
    }
    try {
        if (isset($params['qty'])) {
            $filter = new Zend_Filter_LocalizedToNormalized(
                array('locale' => Mage::app()->getLocale()->getLocaleCode())
            );
            $params['qty'] = $filter->filter($params['qty']);
        }

        $quoteItem = $cart->getQuote()->getItemById($id);
        if (!$quoteItem) {
            Mage::throwException($this->__('Quote item is not found.'));
        }

        $item = $cart->updateItem($id, new Varien_Object($params));
        if (is_string($item)) {
            Mage::throwException($item);
        }
        if ($item->getHasError()) {
            Mage::throwException($item->getMessage());
        }

        $related = $this->getRequest()->getParam('related_product');
        if (!empty($related)) {
            $cart->addProductsByIds(explode(',', $related));
        }

        $cart->save();

        $this->_getSession()->setCartWasUpdated(true);

        Mage::dispatchEvent('checkout_cart_update_item_complete',
            array('item' => $item, 'request' => $this->getRequest(), 'response' => $this->getResponse())
        );
        if (!$this->_getSession()->getNoCartRedirect(true)) {
            if (!$cart->getQuote()->getHasError()) {
                $message = $this->__('%s was updated in your shopping cart.', Mage::helper('core')->escapeHtml($item->getProduct()->getName()));
                $this->_getSession()->addSuccess($message);
            }
            $this->_goBack();
        }
    } catch (Mage_Core_Exception $e) {
        if ($this->_getSession()->getUseNotice(true)) {
            $this->_getSession()->addNotice($e->getMessage());
        } else {
            $messages = array_unique(explode("\n", $e->getMessage()));
            foreach ($messages as $message) {
                $this->_getSession()->addError($message);
            }
        }

        $url = $this->_getSession()->getRedirectUrl(true);
        if ($url) {
            $this->getResponse()->setRedirect($url);
        } else {
            $this->_redirectReferer(Mage::helper('checkout/cart')->getCartUrl());
        }
    } catch (Exception $e) {
        $this->_getSession()->addException($e, $this->__('Cannot update the item.'));
        Mage::logException($e);
        $this->_goBack();
    }
    $this->_redirect('*/*');
}

The call to $this->_goBack() in the end of the try-block seems to set the redirect URL correctly by looking at settings and a 'return_url' parameter (and I've verified that the code gets this far). But, as you can see, the last line always sets a redirect to */* no matter what. Just adding a return statement after the _goBack() call fixes the problem but I rather do this without modifying the core files.

Any ideas how I can solve this problem?

Best Answer

If you want the customer to say on the update page you could

Use Ajax to post the changes to the server.
Add a return_url parameter to your post action (with the current url see protected function _goBack())
Change the global behavior for adding and updatig product in System -> Configuration -> Sales tab -> Checkout and then in the Shopping Cart tab you set the After Adding a Product Redirect to Shopping Cart
Rewrite the controller using a custom module

Related Solutions

Product Cart Redirect – Redirect to Same Product URL After Add to Cart Error

You would need to write an extension that adds a good bit of info that isn't passed by default. There's no Magento setting that would achieve this.

If you look at the addProduct function in app\code\Core\Mage\Checkout\Model\Cart.php, the $requestInfo only includes the product id, which in turn is used later on the get the url that you are returned to. There's no way of Magento knowing which category you're coming from because the only thing passed in the product id.

Inside of that function you will see a comment stating "String we can get if prepare process has error". The code right below this is where the redirect url is generated using $product->getUrlModel()->getUrl..

There are several ways you could extend this to get the result you want. One way would be to get the first category for the product and change the way the $redirectUrl is generated so that it always includes that category.

Another method might be to pass along the referer url that's available in the initial request which would be located in the addAction function in app\code\core\Mage\Checkout\controllers\CartController.php. You could add it as part of the params that gets passed to the addProduct function in the Model. The referer url will have the category as part of the url.

Disable Redirect After Adding Product to Basket in Magento

If you look into the cart controller app/code/core/Mage/Checkout/controllers/CartController.php your will find the function _goBack. This is where the return url is decided by Magento.

protected function _goBack()
{
    $returnUrl = $this->getRequest()->getParam('return_url');
    if ($returnUrl) {

        if (!$this->_isUrlInternal($returnUrl)) {
            throw new Mage_Exception('External urls redirect to "' . $returnUrl . '" denied!');
        }

        $this->_getSession()->getMessages(true);
        $this->getResponse()->setRedirect($returnUrl);
    } elseif (!Mage::getStoreConfig('checkout/cart/redirect_to_cart')
        && !$this->getRequest()->getParam('in_cart')
        && $backUrl = $this->_getRefererUrl()
    ) {
        $this->getResponse()->setRedirect($backUrl);
    } else {
        if (($this->getRequest()->getActionName() == 'add') && !$this->getRequest()->getParam('in_cart')) {
            $this->_getSession()->setContinueShoppingUrl($this->_getRefererUrl());
        }
        $this->_redirect('checkout/cart');
    }
    return $this;
}

The section your are looking for is the call to _getRefererUrl this happens when you are not setting the return url as a parameter and not using the default redirect to cart option.

Inside the function _getRefererUrl the referrer url is checked to see if it is an internal url, when it is not internal than the base url is used.

I would suggest that either your referrer url is external or there is something wrong with the check.

Have a look at Mage_Core_Controller_Varien_Action::_isUrlInternal to debug if the url is internal or not.

Problem was that _isUrlInternal was failing because of having the port in the base url

Best Answer

Related Solutions

Product Cart Redirect – Redirect to Same Product URL After Add to Cart Error

Disable Redirect After Adding Product to Basket in Magento

Related Topic