How to Override Cart Controller Twice or Only Override /checkout/cart/delete

controllersonestepcheckoutoverrides

In a shop using Idev_OneStepCheckout I need to override the deleteAction. OSC doesn't do this, but it does override Mage_Checkout_CartController, only for the _goBack() method. The shop also has a storeview that uses the standard OnePage checkout from Magento.

So, unfortunately, I can't do:

<frontend>
  <routers>
     <checkout>
       <args>
         <modules>
           <MyNameSpace_MyModule before="Idev_OneStepCheckout">MyNameSpace_MyModule_OneStepCheckout</MyNameSpace_MyModule>
           <MyNameSpace_MyModule before="Mage_Checkout">MyNameSpace_MyModule</MyNameSpace_MyModule>
         </modules>
       </args>
     </checkout>
   </routers>
 </frontend>

Well, I can, but my module isn't called in the OSC case. Disabling either makes it work for the checkout in question, so I know my code is correct.
Do I have to resort to a rewrite of /checkout/cart/delete for the onepage case or is there a more elegant solution?

Best Answer

I'm not sure I follow all your concerns, so apologies if this doesn't answer your question, but I'd approach this by

Creating a custom module
Adding a <modules/>/before="Idev_OneStepCheckout" "rewrite"
Have your new controller class extend the specific Idev_OneStepCheckout you're after

With the above in place you'll have the exact same functionality as you currently do, and then can replace whatever methods you want.

Instead of thinking of these as controller rewrites, it helps to think of them like this

When a request for a URL that looks like /checkout/... comes in, here's a list of module to look for controllers in

So you're not replacing controller files, you'll telling Magento "use my controller instead". Then, if your controller extends the older controller, you get the same behavior. A subtle different, but sometimes it helps people understand what's going on better. The Idev folks did this for their module — if you do it for yours and tell Magento to check it first (i.e. the before) you should be set.

Related Solutions

Magento 1.8 – How to Override a Controller

In my humble opinion:

Rewriting controllers is recipe for disaster and makes code management a nightmare. Every plugin developer (or every store developer / systems integrator) truly believes that there will never be another plugin rewriting the same controller. The fact is, though, that one day it will happen (in the case of CartController.php it happens way too often). In my experience you then have to rewrite two plugins to create a chained inheritance. This is non-optimal.

So. In my opinion, instead, you should always use controller dispatch events. In your case the event looks something like this:

<?xml version="1.0"?>
<config>
    <global>
        <events>
            <controller_action_predispatch_catalog_category_view>
                <observers>
                    <yourcompany_capccv_predispatch>
                        <class>YourCompany_YourModule_Model_Observer</class>
                        <method>catalogCategoryViewPredispatch</method>
                    </yourcompany_capccv_predispatch>
                </observers>
            </controller_action_predispatch_catalog_category_view>
        </events>
    </global>
</config>

And the observer model:

<?php

class YourCompany_YourModule_Model_Observer
{

    public function catalogCategoryViewPredispatch($observer)
    {
        $helper = Mage::helper('core');
        $controller = $observer->getEvent()->getControllerAction();

        Mage::log("this works");

        //you can intercept and massage data on the request object
        $request = $controller->getRequest();
        $params = $request->getParams();

        $request->setParam('escapeme', $helper->escapeHtml($params['escapeme']));
    }
}

Override Magento Core Abstract Controller

You cannot override that controller.
Well...actually you can but it will have no effect.
The Mage_Adminhtml_Controller_Action class is never instantiated. It is there as a common parent class for the rest of the admin controllers.
even if you find a way to rewrite it all the other admin controllers will extend the original class so your modification will be useless.

If you want to change something in it you have to copy it to app/code/local/Mage/Adminhtml/Controller/Action.php and make your modifications there.

Here are more details about why you cannot rewrite some classes in Magento

Best Answer

Related Solutions

Magento 1.8 – How to Override a Controller

Override Magento Core Abstract Controller

Related Topic