Magento 1.9 PDF Invoice – Draw Line Between Items

In the same file the Mage_Sales_Model_Order_Pdf_Abstract::insertOrder method is what draws the header part of the PDF. To change gray background to white, change:

$page->setFillColor(new Zend_Pdf_Color_GrayScale(0.45));

to

$page->setFillColor(new Zend_Pdf_Color_GrayScale(1));

before the line

$page->drawRectangle(25, $top, 570, $top - 55);

To change color to black in the same file change:

$page->setFillColor(new Zend_Pdf_Color_GrayScale(1));

to

$page->setFillColor(new Zend_Pdf_Color_GrayScale(0));

right after drawRectangle call.

You will have to do the same in Mage_Sales_Model_Order_Pdf_Abstract::insertDocumentNumber() because that is where Invoice # is added.

With all of the above said, you are better off with doing local module which overrides the abstract class or the invoice class. And in it just change what you need. This way in case of future changes in the Abstract.php file in core code pool you will inherit new features and retain your changes as well.

First of all, copying files that can just be overridden from the Core to Local is not best practise as it can possibly give you more work when upgrading Magento.

I have tested your case and found your solution:

First of all I rewrite it in my own extension:

 <models>
            <sales>
                <rewrite><order_pdf_items_invoice_default>MycompanyName_Myextensionname_Model_Order_Pdf_Items_Invoice_Default</order_pdf_items_invoice_default></rewrite>
            </sales>
 </models>

Then I override the function you mentioned above:

 $options = $this->getItemOptions();
    if ($options) {
        foreach ($options as $option) {
            if ($option['value']) {
                if (isset($option['print_value'])) {
                    $_printValue = $option['print_value'];
                } else {
                    $_printValue = strip_tags($option['value']);
                }
                $values = explode(', ', $_printValue);
                foreach ($values as $value) {
                    $lines[][] = array(
                        'text' => Mage::helper('core/string')->str_split(strip_tags($option['label'] . " - " . $value), 40, true, true),
                        'feed' => 40
                    );
                }
            }
        }
    }

What I have done here is just removed the part where you draw the label and added it to the part where you print the value.

If you have long labels/values and you want to keep it on one line, I would increase the value in str_split.