Rewriting app/code/core/Mage/Catalog/controllers/Product/CompareController.php in Magento 1

controllersmoduleoverrides

I am trying to rewrite app/code/core/Mage/Catalog/controllers/Product/CompareController.php. In my config.xml I have the following:

<frontend>
  <routers>
    <catalog>
      <args>
        <modules>
          <Slice_CustomCompare before="Mage_Catalog">Slice_CustomCompare_Catalog_Product_Compare</Slice_CustomCompare>
        </modules>
      </args>
    </catalog>
  </routers>
</frontend>

and in app/code/local/Slice/CustomCompare/controllers/Product/CompareController.php I have:

<?php
require_once(Mage::getModuleDir('controllers','Mage_Catalog').DS.'CompareController.php');
class Slice_CustomCompare_Product_CompareController extends Mage_Catalog_Product_CompareController {

  public function removeAction() {
    Mage::log('Slice_CustomCompare_Product_CompareController:removeAction');
  }
}
?>

When I try to remove a product from the compare list I don't get Slice_CustomCompare_Product_CompareController:removeAction in my logs. Instead I get output that I added to the method in the core code. What am I missing? Why is my rewrite not working?

Best Answer

Your config section should look like this:

<frontend>
  <routers>
    <catalog>
      <args>
        <modules>
          <Caupo_CustomCompare before="Mage_Catalog">Caupo_CustomCompare</Caupo_CustomCompare>
        </modules>
      </args>
    </catalog>
  </routers>
</frontend>

This means that Magento looks for a controller in Caupo/CustomCompare/controllers before looking in Mage/Catalog/controllers.
The controller path must follow the same file path as the original controller (but looks like you already have that:)

Mage /Catalog      /controllers/Product/CompareController.php - original controller
Caupo/CustomCompare/controllers/Product/CompareController.php - your controller
\____/\____________/\________________________________________/
   |       |                          |
   |       |                          |---Common path to controller
   |       |--- Module
   |---- Namespace

And your require statement should be like this:

require_once('Mage/Catalog/controllers/Product/CompareController.php');

I think it works with this also but I'm not sure:

require_once(Mage::getModuleDir('controllers','Mage_Catalog').DS.'controllers'.DS.'Product'.DS.'CompareController.php');

Related Solutions

Making Edits to Core Controllers OnepageController.php in Magento 1.9

Config.xml is code

<?xml version="1.0"?>
<config>
<modules>
    <PaypalExtended_OnepagePaypal>
        <version>0.1.0</version>
    </PaypalExtended_OnepagePaypal>
</modules>
<!--
<frontend>
    <routers>
        <checkout>
            <args>
             <modules>
               <PaypalExtended_OnepagePaypal before="Mage_Checkout">PaypalExtended_OnepagePaypal_Checkout</PaypalExtended_OnepagePaypal>
                </modules>
            </args>
        </checkout>
    </routers>
</frontend>
-->
<global>
        <!-- This rewrite rule could be added to the database instead -->
        <rewrite>
            <!-- This is an identifier for your rewrite that should be unique -->
            <!-- THIS IS THE CLASSNAME IN YOUR OWN CONTROLLER -->
            <customonepageunique>
                <from><![CDATA[#^/checkout/onepage/#]]></from>
                <!--
                    - mymodule matches the router frontname below
                    -  matches the path to your controller

                    Considering the router below, "/customonepage/index/" will be
                    "translated" to "app/code/local/PaypalExtended/OnepagePaypal/controllers/Checkout/OnepageController.php" (?)
                -->
                <to>/customonepage/checkout_onepage/</to>
            </customonepageunique>
        </rewrite>
    </global>

    <frontend>
        <routers>
            <customonepage>
                <!-- should be set to "admin" when overloading admin stuff (?) -->
                <use>standard</use>
                <args>
                    <module>PaypalExtended_OnepagePaypal</module>
                    <!-- This is used when "catching" the rewrite above -->
                    <frontName>customonepage</frontName>
                </args>
            </customonepage>
        </routers>
    </frontend>
</config>

controller code is

 <?php
  # Controllers are not autoloaded so we will have to do it manually: 
  require_once Mage::getModuleDir('controllers', "Mage_Checkout").DS."OnepageController.php";
  class PaypalExtended_OnepagePaypal_Checkout_OnepageController extends    Mage_Checkout_OnepageController
  {
/**
 * Save payment ajax action
 *
 * Sets either redirect or a JSON response
 */
 public function indexAction(){

    die("eee");
 }
public function savePaymentAction()
{
   if ($this->_expireAjax()) {
        return;
    }
    try {
        if (!$this->getRequest()->isPost()) {
            $this->_ajaxRedirectResponse();
            return;
        }

        $data = $this->getRequest()->getPost('payment', array());

 //BEGIN ONLY EDIT TO FUNCTION
if(array_search('paypal_express_cc',$data)!= false)
        {
         Mage::getSingleton('core/session')->setData('paypal_express_onepage', 'BILLING');
        // $data[array_search('',paypal_express_cc'',$data)] = 'paypal_express';
        }
//END ONLY EDIT TO FUNCTION


        $result = $this->getOnepage()->savePayment($data);

        // get section and redirect data
        $redirectUrl = $this->getOnepage()->getQuote()->getPayment()->getCheckoutRedirectUrl();
        if (empty($result['error']) && !$redirectUrl) {
            $this->loadLayout('checkout_onepage_review');
            $result['goto_section'] = 'review';
            $result['update_section'] = array(
                'name' => 'review',
                'html' => $this->_getReviewHtml()
            );
        }
        if ($redirectUrl) {
            $result['redirect'] = $redirectUrl;
        }
    } catch (Mage_Payment_Exception $e) {
        if ($e->getFields()) {
            $result['fields'] = $e->getFields();
        }
        $result['error'] = $e->getMessage();
    } catch (Mage_Core_Exception $e) {
        $result['error'] = $e->getMessage();
    } catch (Exception $e) {
        Mage::logException($e);
        $result['error'] = $this->__('Unable to set Payment Method.');
    }
    $this->getResponse()->setBody(Mage::helper('core')->jsonEncode($result));
}
 }

How to override, a controller see my blog http://www.amitbera.com/how-to-override-a-controller-in-magento/

Magento 1.9 – Edits to Core Controllers OnepageController.php Not Working

Hi i have try basic Magento redirect,It is working

I have modify config.xml now, it is working

<?xml version="1.0"?>
<config>
<modules>
    <PaypalExtended_OnepagePaypal>
        <version>0.1.0</version>
    </PaypalExtended_OnepagePaypal>
</modules>
<!--
<frontend>
    <routers>
        <checkout>
            <args>
             <modules>
               <PaypalExtended_OnepagePaypal before="Mage_Checkout">PaypalExtended_OnepagePaypal_Checkout</PaypalExtended_OnepagePaypal>
                </modules>
            </args>
        </checkout>
    </routers>
</frontend>
-->
<global>
        <!-- This rewrite rule could be added to the database instead -->
        <rewrite>
            <!-- This is an identifier for your rewrite that should be unique -->
            <!-- THIS IS THE CLASSNAME IN YOUR OWN CONTROLLER -->
            <customonepageunique>
                <from><![CDATA[#^/checkout/onepage/#]]></from>
                <!--
                    - mymodule matches the router frontname below
                    -  matches the path to your controller

                    Considering the router below, "/customonepage/index/" will be
                    "translated" to "app/code/local/PaypalExtended/OnepagePaypal/controllers/Checkout/OnepageController.php" (?)
                -->
                <to>/customonepage/checkout_onepage/</to>
            </customonepageunique>
        </rewrite>
    </global>

    <frontend>
        <routers>
            <customonepage>
                <!-- should be set to "admin" when overloading admin stuff (?) -->
                <use>standard</use>
                <args>
                    <module>PaypalExtended_OnepagePaypal</module>
                    <!-- This is used when "catching" the rewrite above -->
                    <frontName>customonepage</frontName>
                </args>
            </customonepage>
        </routers>
    </frontend>
</config>

It is more efficient Process

Best Answer

Related Solutions

Making Edits to Core Controllers OnepageController.php in Magento 1.9

Magento 1.9 – Edits to Core Controllers OnepageController.php Not Working

Related Topic