Event Observer – sales_order_creditmemo_save_after Triggers sales_order_invoice_save_after

event-observer

I have an observer listening for events that fire sales_order_creditmemo_save_after. The issue I have is that when a credit memo is saved on the invoice, the sales_order_invoice_save_after event is also fired – which causes issues with my code, because I also have another observer listening on that event.

For the observer listening on sales_order_invoice_save_after – is there a way to distinguish whether the event was a credit memo or an invoice?

I have found deep down in the $observer object, protected '_historyEntityName' => string 'creditmemo' (length=10) however is there a more standard way to access this information?

Best Answer

The work around was to add a conditional check on the sales_order_invoice_save_after to look for the order status label. Because I only needed the observer to work when the order status was 'Processing', I was able to use:

if ($order->getStatusLabel() == 'Processing')

However I am yet to find a way to access protected '_historyEntityName' => string 'creditmemo' (length=10) in the observer object.

Related Solutions

Magento 1.8 – Can a Core Module Depend on a Custom Module?

I think you can use dependancy concept for this .

Suppose your module be Yoursite_Yourmodule. Then use the following code in the location app/etc/Yoursite_Yourmodule.xml

<config>
    <modules>
        <Yoursite_Yourmodule>
            <active>true</active>
            <codePool>local</codePool>
        </Yoursite_Yourmodule>
        <Mage_Review>
            <depends>
                <Yoursite_Yourmodule />
            </depends>
        </Mage_Review>
     </modules>
</config>

What this code does is, it will make the module Mage_Review depends on your module and hence your module will load bofore the core module does. This will make your observer listen first .

I think this may solve your problem.

Orders – Observer on sales_order_invoice_save_after Event

This is a somewhat older question but I ran into the same situation where I needed this. I came up with what I think is a more elegant solution by comparing the 'created at' and 'updated at' date/time stamps of the invoice. If they are the same it's a new invoice, if they aren't, it's an update.

In code:

$_invoice = $observer->getEvent()->getInvoice();
if ($_invoice->getUpdatedAt() == $_invoice->getCreatedAt()) {

    // Logic for new invoices

} else {

    // Logic for when invoice is updated

}

Hope this helps for other people needing this in the future.

Best Answer

Related Solutions

Magento 1.8 – Can a Core Module Depend on a Custom Module?

Orders – Observer on sales_order_invoice_save_after Event

Related Topic