Magento – Security Patch SUPEE-11155 – Possible issues

23rd February 2016 Update: The patch has been updated to V1.1, which fixes a number of important issues listed in this post, here is the list:

• Cart Merge Patch (SUPEE-7978) : Carts with identical items now merge correctly. Previously, when a cart with one item was merged with another cart that contained the same item, Magento did not merge the cart totals correctly. The cart now includes only one item, and the total is correct.
• SOAP API Patch (SUPEE-7822) : The Magento SOAP API now works as expected. Previously after installing the SUPEE-7405 v1.0 patch, an API request would cause a 500 error, and Magento would log an exception.
• PHP 5.3 Compatibility (SUPEE-7882) : The patch was not compatible with PHP 5.3 for earlier versions of Magento that were still supporting this version. Merchants experiencing this issue were unable to view sales information in the Admin.
• Upload File Permissions : The patch restores less restrictive file permissions (0666 for files and 0777 for directories) as more strict permissions introduced by the original SUPEE-7405 patch caused many merchants not to be able to view uploaded product images, depending on hosting provider configuration.

After digging into the patch, here are the relevant / interesting things I've found (N.B.: this list has been made by analyzing the patch for CE 1.9.2.0-1.9.2.2, there's probably more for patches affecting older versions of Magento) :

• (fixed in V1.1 of the patch) The use of [] instead of array() in this patch makes it backward incompatible with PHP < 5.4 (see known issues below)
• As stated, most of the changes are html escaping and data sanitizing regarding XSS issues.
• Form key validation has been added to the admin login in Mage_Admin_Model_Observer
• Form key validation has been added to the admin forgot password in Mage_Adminhtml_IndexController
• Form key validation has been added to the admin reset password in Mage_Adminhtml_IndexController
• Form key validation has been added to the frontend cart delete action. Form key is added to the getDeleteUrl of Mage_Checkout_Block_Cart_Item_Renderer and validated in the deleteAction of Mage_Checkout_CartController.
• Events are now dispatched all lower case (every config files affected have been modified e.g. controller_action_postdispatch_checkout_onepage_saveOrder becomes controller_action_postdispatch_checkout_onepage_saveorder). This does not affect your local observers configuration. More information here: https://twitter.com/foomanNZ/status/689924329065164800
• A new validator to check if an uploaded file is an image has been added: Mage_Core_Model_File_Validator_Image
• A new Import/Export section appears : System => Configuration =>Advanced > System => Escape CSV Fields
• New event dispatched: admin_user_validate under Mage_Admin_Model_User
• SVG is not a valid favicon extension anymore
• For those using Authorizenet (I don't) it seems like a few changes have been made, not sure how it impacts the system though. Changes include a new admin helper (Mage_Authorizenet_Helper_Admin) used to get the success order url.
• New Zend class: Zend_Xml_Security. Its purpose is to scan XML string for potential XXE and XEE attacks. However I did not find any reference to it in the other modified files.
• Files uploaded via admin panel (i.e. product image upload) are now not world readable by default (before: 777 / after: 640).
• Directories are also not world executable (before 755 / after: 750). This two can cause issues with images not appearing on the website if the webserver runs as a different user from php (credits: @Rob Mangiafico)
• Regarding frontend templates: the only modifications made are data escaping, which are not system breakers but still recommended to implement on your custom theme (and there's only two frontend files affected not that much work ;) )

Known issues after patching:

I'll try to keep this list as up to date as possible.

Before starting a new issue/question, please ensure you've applied all the previous patches as it seems like a lot of issues comes from missing patches.

Another thing is: if you have modified core files, applying the patch may fail. If you're having a Hunk # failed at error for a specific file and you're 100% sure you've applied all the previous patches, please ensure you have the original file from your Magento version by checking the mirror: https://github.com/OpenMage/magento-mirror/

• Dropped sessions issue (with fix) (https://magento.stackexchange.com/a/116324/2380)
• Unable to login to the backend after the patch: "Invalid form key" error. => Flush your browser cookies and delete the var/session files (Magento 1.9.2.3. not login in google chrome)
• (fixed in v1.1 of the patch) Admin order view page is blank / broken => Related to the PHP < 5.4 incompatibility. => Fix can be found here: https://magento.stackexchange.com/a/98237/2380 / I've created a bug report: https://www.magentocommerce.com/bug-tracking/issue/index/id/1266 (credits: @Moonman67).
• (fixed in v1.1 of the patch) SOAP API URL /index.php/api/v2_soap/index/?wsdl=1 throws a 500 error => I've developped a hacky fix for this one that can be found here: https://magento.stackexchange.com/a/98790/2380 / I've also created a bug report for this one: https://www.magentocommerce.com/bug-tracking/issue/index/id/1265 (credits: @Moonman67)
• (fixed in v1.1 of the patch) Issues regarding file upload permissions
• Applying patch on Magento 1.7.0.0 breaks: https://magento.stackexchange.com/a/98246/2380
• Checkout not redirecting to success page on HHVM: https://magento.stackexchange.com/a/98334/2380
• Undefined class constant AREA ADMINHTML in app/code/core/Mage/Core/Model/Config.php (possibly EE only): SUPEE 7405 Enterprise Edition Fatal error Undefined class constant 'AREA_ADMINHTML
• Call to undefined method Mage_Core_Helper_Abstract::escapeHtml() on 1.4.0.1 : Error after installing patch 7405 on Magento 1.4.0.1
• Mage registry key _singleton/Mage_Core_Model_Domainpolicy already exists on Magento 1.7: Security Patch SUPEE-7405 Error
• Call to a member function getUsername() on a non-object after the patch: Magento Admin thrown error after applying SUPEE 7405 security patch
• Unable to add permission block after patch on 1.8.1.0 : After Security patch supee-7405 topmenu is not displaying
• (Previous patch not applied) Issues applying the patch on 1.7.0.2 : Security Patch SUPEE-7405 Issues
• (Core files had been changed) Issues applying the patch on 1.8.1 : supee 7405 Hunk #2 FAILED at 472. Magento 1.8.1
• (Provider related) Email queue broken after patch : Magento 1.9.2.3 Email-Queue not working

List of affected files

It can be found on this page here: https://magento.stackexchange.com/a/98232/2380 (credits @MagenX)

EE Only

• If you updated from Magento EE 1.14.2.x to Magento EE 1.14.2.3 instead of applying the patch, and also applied the support patch SUPEE-5984 before, you have to reapply it again because it is not included in the release. => https://magento.stackexchange.com/a/98805/2380

Regarding Patch 7616:

• Seems like patches 4291 and 6237 need to be applied before applying the patch. More information here: Apply 7616_EE 7405_EE patch not successfuly
• (Patch 5344 had not been applied) Possible problem when applying 7616 before applying 7405: SUPEE 7405 - Hunk #2 Failed at 43

Good resources about Magento patches

• Critical Reminder: Download and install Magento security patches. (FTP with no SSH access)
• Mage Report has added a check for SUPEE-7405: https://www.magereport.com/

Feel free to let me know if I miss something.

Here's my overview of the patch after digging into it

TIME SAVER : Experius provides a patch helper that helps you finding the files in custom themes, custom modules or local overwrites that also might need to be patched manually, you can find it here: https://github.com/experius/Magento-1-Experius-Patch-Helper#magento

Checkout form keys

As said in the other post, this patch adds form keys to the following forms:

Shipping cart form:

app/design/frontend/<package>/<theme>/template/checkout/cart/shipping.phtml

Multishipping billing checkout form:

app/design/frontend/<package>/<theme>/template/checkout/multishipping/billing.phtml

Multishipping shipping checkout form:

app/design/frontend/<package>/<theme>/template/checkout/multishipping/shipping.phtml

Multishipping addresses checkout form:

app/design/frontend/<package>/<theme>/template/checkout/multishipping/addresses.phtml

Billing checkout form:

app/design/frontend/<package>/<theme>/template/checkout/onepage/billing.phtml

Shipping checkout form:

app/design/frontend/<package>/<theme>/template/checkout/onepage/shipping.phtml

Payment checkout form:

app/design/frontend/<package>/<theme>/template/checkout/onepage/payment.phtml

Shipping method checkout form:

app/design/frontend/<package>/<theme>/template/checkout/onepage/shipping_method.phtml

Persistent Billing checkout form:

app/design/frontend/<package>/<theme>/template/persistent/checkout/onepage/billing.phtml

On top of that the following JS files have been updated to be compatible with that change:

• js/varien/payment.js
• skin/frontend/base/default/js/opcheckout.js

What to do:

If you're using with custom versions of those templates you'll have to update them by adding the following code into them:

<?php echo $this->getBlockHtml('formkey') ?>

If you're using a 3rd party checkout module, you'll have to get in touch with them so they can provide an updated version of their module.

Also if you have custom versions of the previously listed JS files, you'll have to update them too.

SAVE YOUR TIME:

Fabian Schmengler wrote a nice little script to update all those things for you, you can find it here:

https://gist.github.com/schmengler/c42acc607901a887ef86b4daa7a0445b

IMPORTANT NOTE : the checkout formkey validation can be changed in the backend via a new config field under System > Configuration > Admin > Security > Enable Form Key Validation On Checkout . THIS IS NOT ENABLED BY DEFAULT so you'll have to enable it to benefit from this security feature!!! Note that you'll get a notice in the backend if it's not enabled.

Image Upload callback

The image gallery controller has been updated to add a validation callback.

What to do

If you're using a custom module that does image upload with code that looks like this:

        $uploader = new Mage_Core_Model_File_Uploader('image');
        $uploader->setAllowedExtensions(array('jpg','jpeg','gif','png'));
        $uploader->addValidateCallback('catalog_product_image',
            Mage::helper('catalog/image'), 'validateUploadFile');
        $uploader->setAllowRenameFiles(true);
        $uploader->setFilesDispersion(true);

I strongly suggest you update that code by adding the following piece after it:

        $uploader->addValidateCallback(
            Mage_Core_Model_File_Validator_Image::NAME,
            Mage::getModel('core/file_validator_image'),
            'validate'
        );

Symlinks

This patch removes the system configuration field that allows you to allow template symlinks in the backend. It used to be under System > Configuration > Developer > Template > Allow Symlinks . Now the entire Template section is gone.

On top of that, that field is now disabled by default via the app/etc/config.xml

The funny thing here is that you'll get a notice in the backend if you have that configuration field enabled prior to the patch but you won't be able to disable it as the field is gone.

Only way of doing it is by running the following SQL query

UPDATE core_config_data SET value = 0 WHERE path = "dev/template/allow_symlink";

Clarification

First I strongly suggest you check those two posts that will help you understand the purpose of that Symlink modification:

• From Peter O'Collaghan: https://peterocallaghan.co.uk/2017/06/appsec-1281-dangerous-symlinks/
• From Max Chadwick: https://maxchadwick.xyz/blog/what-allow-symlinks-actually-does

This modification is really about calling uploadable content (like images) via template directives.

The issue related to symlinks is exploitable only with admin access and Magento added some more protection around image uploads as well.

Please note that they are some protections against known way to exploit it in addition to the setting itself.

What to do: if like me, you're using modman or composer with template symlinks, you're gonna face some issues. I'm still trying to find out what's the best thing to do here apart from dealing with SQL queries.

Main post regarding this issue: SUPEE-9767, modman and symlinks

List of possible issues

V2 was released since that original post. Don't forget to upgrade

Bugs

The word 'confirmed' is used for confirmed bugs. If it's not there, that means it could be a bug but hasn't been confirmed yet.

• Customer registration fails at checkout CONFIRMED & FIXED IN V2
• PHP7 and EE bug CONFIRMED
• Bug with EE, FPC and Design Exceptions CONFIRMED
• Add to cart and cookie bug in EE CONFIRMED
• Multishipping broken after patch CONFIRMED
• Missing bug fix in head-simple.phtml CONFIRMED & FIXED IN V2
• Admin Symlink warning is not displayed on 1.9.2 CONFIRMED & FIXED IN V2
• Watermark get black background when transparent CONFIRMED & FIXED IN V2
• Unable to upgrade via Magento Connect
• Infinite redirect loop on 1.6.0.0

Hunk Failed Issues

Note that all those issues could be simply because you modified the original file, to double check that this is not the case:

• Backup the file where you get the Hunk Failed error
• Download the original file from your Magento version
• Compare both files

If files are different you'll have to apply the patch with the original file then reapply your custom changes the clean way such as:

• custom template in a custom theme folder
• local.xml
• app/code/local file

If files are not different then this is either a permission issue or a "bug" in the patch.

• patching file app/design/frontend/rwd/default/layout/page.xml Hunk #1 FAILED at 36.
• patching file app/design/frontend/enterprise/default/template/persistent/checkout/onepage/billing.phtml Hunk #1 FAILED at 225.
• patching file app/code/core/Enterprise/PageCache/Model/Observer.php Hunk #6 FAILED at 1093.
• patching file app/code/core/Mage/Core/etc/system.xml Hunk #3 FAILED at 1355.
• patching file app/code/core/Mage/Sales/Model/Quote/Item.php Hunk #1 FAILED at 500.
• Hunk failed on 1.8.0.0