Magento 1.8 – Stock Quantity Not Increasing After Cancellation

magento-1.8ordersstock

I have installed Magento 1.8. When a user orders a product, the quantity is decreased by one, but if he cancels that order (before invoicing), the stock quantity does not gets increased.

Admin > Catalog > Inventory > Stock Options > Set Items Status to be In Stock When Order is Cancelled is set to Yes

The code I have been using to cancel order is as follows:

class Kaushikamdotcom_Pay_OrderController extends Mage_Core_Controller_Front_Action {
    public function cancelAction() {
        if (($order_id = $this->getRequest()->getParam('order_id'))) {
            $order = Mage::getModel('sales/order')->load($order_id);

            $order->setState(Mage_Sales_Model_Order::STATE_CANCELED, true);
            $order->save();
        }

        $this->_redirect('sales/order/history');
    }
}

The code I have been using to know the current stock is as follows (The same can be also seen in the admin side):

Mage::getModel('cataloginventory/stock_item')->loadByProduct($_product)->getQty();

Why is the quantity not get increased ? Is it the intended behavior ? I searched in google, on those links I have been instructed to do it programmatically.

Best Answer

You can try below code for cancelling an order.

$orderModel = Mage::getModel('sales/order');
$orderModel->load($orderId);
if(!$orderModel->canCancel()) {
$orderModel->cancel();
$orderModel->setState(Mage_Sales_Model_Order::STATE_CANCELED, true)->save();
$orderModel->save();
}

In your code, actual code is missing for cancel the order, you had never called cancel() function of class Mage_Sales_Model_Order

Related Solutions

Magento – Custom cron causing one page checkout deadlocks

Adding a sleep(3) to allow the db to settle in between cancel transactions could be a good workaround.

Magento – How to Stop Decreasing Stock Quantity When Order is Placed

This is how I soved my problem
Reff: http://www.magentocommerce.com/wiki/groups/132/protx_form_-_subtracting_stock_on_successful_payment

I have 2 payment menthods 1) CCavenue and 2) COD. I only wanted to stop the stock decrease to be done only on the CCavenue orders, so I used this.

The stock is credited back to the system when the customer is redirected to the payment gateway using this code.

if(!isset($_SESSION['updated']) || $_SESSION['updated'] != $session->getLastRealOrderId()) {

            $items = $order->getAllItems(); // Get all items from the order
            if ($items) {
                foreach($items as $item) {
                    if ($item->getParentItem()) { 
                        continue;
                    }
                        $quantity = $item->getQtyOrdered(); // get Qty ordered
                        $product_sku = $item->getSku(); // get it's sku
                    $product = Mage::getModel('catalog/product')->loadByAttribute('sku',$product_sku);
                    if($product){               
                        $stock = Mage::getModel('cataloginventory/stock_item')->loadByProduct($product); // Load the stock for this product
                        $stock->setQty($stock->getQty()+$quantity); // Set to new Qty           
                        $stock->save(); // Save
                    }
                }
            }
            $_SESSION['updated'] = $session->getLastRealOrderId();
            /* end stock addition */
        }

I added this code in the redirectAction in the paymentController.php of the payment extension. And in the responseAction I added the below code which re-deducts the stock when the payment is successful.

$items = $order->getAllItems(); // Get all items from the order
if ($items) {
    foreach($items as $item) {

        if ($item->getParentItem()) { 
            continue;
        }
            $quantity = $item->getQtyOrdered(); // get Qty ordered
            $product_sku = $item->getSku(); 
        $product = Mage::getModel('catalog/product')->loadByAttribute('sku',$product_sku);
        if($product){

            $stock = Mage::getModel('cataloginventory/stock_item')->loadByProduct($product); // Load the stock for this product
            $stock->setQty($stock->getQty()-$quantity); // Set to new Qty           
            $stock->save(); // Save
        }
    }
}

Most of my products are configurable products. When I tried to get the item details from the order items collection it was giving me two values one for configurable and the other for simple product. Since I wanted to reduce the stock for only simple product I used SKU in the above codes to load the simple product.

My other problem was the cron I was running to cancel the abandoned transaction orders credits the stock back to the system when the order is cancelled. To fix this I copied app/code/core/Mage/Sales/Model/Order/Item.php into
app/code/local/Mage/Sales/Model/Order/Item.php and modified the cancel function to this so that the stock won't get credited back the abandoned orders are cancelled.

if ($this->getStatusId() !== self::STATUS_CANCELED) {
    $order_status = $this->getOrder()->getStatus();
    if($order_status != 'abandoned_payment'){
        Mage::dispatchEvent('sales_order_item_cancel', array('item'=>$this));
    }
    $this->setQtyCanceled($this->getQtyToCancel());
    $this->setTaxCanceled(
        $this->getTaxCanceled() +
        $this->getBaseTaxAmount() * $this->getQtyCanceled() / $this->getQtyOrdered()
    );
    $this->setHiddenTaxCanceled(
        $this->getHiddenTaxCanceled() +
        $this->getHiddenTaxAmount() * $this->getQtyCanceled() / $this->getQtyOrdered()
    );
}

abandoned_payment is my order status for the abandoned orders.

Best Answer

Related Solutions

Magento – Custom cron causing one page checkout deadlocks

Magento – How to Stop Decreasing Stock Quantity When Order is Placed

Related Topic