Magento – Unable to make a direct download link of downloadable product. Links return 404

downloaddownloadablemagento-1.9product-list

I modified my list.php to get the download link button instead of "add to cart" button when I have a free download file.
I know that in this way I can't get statistic of download but for now this is not a problem.

Here my code:

<?php if(!($_product->getIsVirtual() && $_product->getFinalPrice() == 0)): ?>
                        <p class="action"><button type="button" title="<?php echo $this->quoteEscape($this->__('Add to Cart')) ?>" class="button btn-cart" onclick="setLocation('<?php echo $this->getAddToCartUrl($_product) ?>')"><span><span><?php echo $this->__('Add to Cart') ?></span></span></button></p>

                            <?php else:
                            $_myprodlinks = Mage::getModel('downloadable/link');
                            $_myLinksCollection = $_myprodlinks->getCollection()->addProductToFilter($_product->getId());
                            if (sizeof($_myLinksCollection)>0):
                            foreach ($_myLinksCollection as $_link):
                            $mediaUrl = Mage::getBaseUrl(Mage_Core_Model_Store::URL_TYPE_MEDIA);
                            $_linkpath = $mediaUrl."downloadable/files/links".$_link->getLinkFile();
                            ?>
                                <a href="<?php echo $_linkpath ?>" target="_blank" title="<?php echo Mage::helper('core')->quoteEscape(Mage::helper('downloadable')->__('Start Download')) ?>"><button type="button" title="<?php echo Mage::helper('core')->quoteEscape(Mage::helper('downloadable')->__('Start Download')) ?>" class="button btn-cart"><span><span><?php echo Mage::helper('core')->quoteEscape(Mage::helper('downloadable')->__('Start Download')) ?></span></span></button></a>
                            <?php
                             endforeach;
                             endif;?>       
                        <?php endif;?>

This works fine! I have the button and the link has the right url like this

http://my-site.com/media/downloadable/files/links/a/u/auguri.pdf

Through FTP I have verified the presence of the file, but this link return me a 404 page.
I have read some similar topics and I tried to change the permission of folders and files, but nothing change.
Any suggestion?

Best Answer

I know this does not solve your problem, but maybe it makes you rework the functionality:

Actually the correct behaviour when accessing files directly from /media/downloadable/ should be a Permission denied.

Why?

Anyone could just do a directory traversal in your /media or /media/downloadable directory and download all the files in there automatically.

If you don't care about this fact: go ahead.

If you do: Try to find another solution to download the files.

You can use the Sample section/function of the downloadable products which is intended to be used to preview the files. Just upload your file there.

Related Solutions

Product List – How to Show Downloadable Link Title and Price

Thoma Louis,

You can this by below step: create Listlinks.php file under app>code>local>Mage>Downloadable>Block>Catalog>Product and code this file:

<?php
class Mage_Downloadable_Block_Catalog_Product_Listlinks extends Mage_Catalog_Block_Product_Abstract
{
    /**
     * Enter description here...
     *
     * @return boolean
     */
       public function setProduct($product) {
        $this->_product = $product;
        return $this;
    }

    public function getProduct() {
        return $this->_product;
    }
    public function getLinksPurchasedSeparately()
    {
        return $this->getProduct()->getLinksPurchasedSeparately();
    }

    /**
     * Enter description here...
     *
     * @return boolean
     */
    public function getLinkSelectionRequired()
    {
        return $this->getProduct()->getTypeInstance(true)
            ->getLinkSelectionRequired($this->getProduct());
    }

    /**
     * Enter description here...
     *
     * @return boolean
     */
    public function hasLinks()
    {
        return $this->getProduct()->getTypeInstance(true)
            ->hasLinks($this->getProduct());
    }

    /**
     * Enter description here...
     *
     * @return array
     */
    public function getLinks()
    {
        return $this->getProduct()->getTypeInstance(true)
            ->getLinks($this->getProduct());
    }

    /**
     * Enter description here...
     *
     * @param Mage_Downloadable_Model_Link $link
     * @return string
     */
    public function getFormattedLinkPrice($link)
    {
        $price = $link->getPrice();
        $store = $this->getProduct()->getStore();

        if (0 == $price) {
            return '';
        }

        $taxCalculation = Mage::getSingleton('tax/calculation');
        if (!$taxCalculation->getCustomer() && Mage::registry('current_customer')) {
            $taxCalculation->setCustomer(Mage::registry('current_customer'));
        }

        $taxHelper = Mage::helper('tax');
        $coreHelper = $this->helper('core');
        $_priceInclTax = $taxHelper->getPrice($link->getProduct(), $price, true);
        $_priceExclTax = $taxHelper->getPrice($link->getProduct(), $price);

        $priceStr = '<span class="price-notice">+';
        if ($taxHelper->displayPriceIncludingTax()) {
            $priceStr .= $coreHelper->currencyByStore($_priceInclTax, $store);
        } elseif ($taxHelper->displayPriceExcludingTax()) {
            $priceStr .= $coreHelper->currencyByStore($_priceExclTax, $store);
        } elseif ($taxHelper->displayBothPrices()) {
            $priceStr .= $coreHelper->currencyByStore($_priceExclTax, $store);
            if ($_priceInclTax != $_priceExclTax) {
                $priceStr .= ' (+'.$coreHelper
                    ->currencyByStore($_priceInclTax, $store).' '.$this->__('Incl. Tax').')';
            }
        }
        $priceStr .= '</span>';

        return $priceStr;
    }

    /**
     * Returns price converted to current currency rate
     *
     * @param float $price
     * @return float
     */
    public function getCurrencyPrice($price)
    {
        $store = $this->getProduct()->getStore();
        return $this->helper('core')->currencyByStore($price, $store, false);
    }

    /**
     * Enter description here...
     *
     * @return string
     */
    public function getJsonConfig()
    {
        $config = array();
        $coreHelper = Mage::helper('core');

        foreach ($this->getLinks() as $link) {
            $config[$link->getId()] = $coreHelper->currency($link->getPrice(), false, false);
        }

        return $coreHelper->jsonEncode($config);
    }

    public function getLinkSamlpeUrl($link)
    {
        return $this->getUrl('downloadable/download/linkSample', array('link_id' => $link->getId()));
    }

    /**
     * Return title of links section
     *
     * @return string
     */
    public function getLinksTitle()
    {
        if ($this->getProduct()->getLinksTitle()) {
            return $this->getProduct()->getLinksTitle();
        }
        return Mage::getStoreConfig(Mage_Downloadable_Model_Link::XML_PATH_LINKS_TITLE);
    }

    /**
     * Return true if target of link new window
     *
     * @return bool
     */
    public function getIsOpenInNewWindow()
    {
        return Mage::getStoreConfigFlag(Mage_Downloadable_Model_Link::XML_PATH_TARGET_NEW_WINDOW);
    }

    /**
     * Returns whether link checked by default or not
     *
     * @param Mage_Downloadable_Model_Link $link
     * @return bool
     */
    public function getIsLinkChecked($link)
    {
        $configValue = $this->getProduct()->getPreconfiguredValues()->getLinks();
        if (!$configValue || !is_array($configValue)) {
            return false;
        }

        return $configValue && (in_array($link->getId(), $configValue));
    }

    /**
     * Returns value for link's input checkbox - either 'checked' or ''
     *
     * @param Mage_Downloadable_Model_Link $link
     * @return string
     */
    public function getLinkCheckedValue($link)
    {
        return $this->getIsLinkChecked($link) ? 'checked' : '';
    }
}

And add the below code in list.phtml

   <?php if($_product->getTypeId()=='downloadable'):?>
                    <?php echo $this->getLayout()->createBlock('downloadable/catalog_product_listlinks')->setTemplate('downloadable/catalog/product/links.phtml')->setProduct($_product)->toHtml();?>

                    <?php endif; ?>

Magento – Unable to Download downloadable products

There may be multiple reason for this. First you need to find out whether Magento gives any errors (exception, errors, report) while you're trying to download the link. Go through - Fundamentals of Debug a Magento store and come again with more details.

For now I can say that, you need to dig in the method linkAction() which is available in the controller class Mage_Downloadable_DownloadController that is located at app/code/core/Mage/Downloadable/controllers/DownloadController.php. More specifically, this is the part of code that you need to dig into.

if ($status == Mage_Downloadable_Model_Link_Purchased_Item::LINK_STATUS_AVAILABLE
        && ($downloadsLeft || $linkPurchasedItem->getNumberOfDownloadsBought() == 0)
    ) {
        ...
        try {
            $this->_processDownload($resource, $resourceType);
            $linkPurchasedItem->setNumberOfDownloadsUsed($linkPurchasedItem->getNumberOfDownloadsUsed() + 1);

            if ($linkPurchasedItem->getNumberOfDownloadsBought() != 0 && !($downloadsLeft - 1)) {
                $linkPurchasedItem->setStatus(Mage_Downloadable_Model_Link_Purchased_Item::LINK_STATUS_EXPIRED);
            }
            $linkPurchasedItem->save();
            exit(0);
        }
        catch (Exception $e) {
            $this->_getCustomerSession()->addError(
                Mage::helper('downloadable')->__('An error occurred while getting the requested content. Please contact the store owner.')
            );
        }
    } elseif ($status == Mage_Downloadable_Model_Link_Purchased_Item::LINK_STATUS_EXPIRED) {
        $this->_getCustomerSession()->addNotice(Mage::helper('downloadable')->__('The link has expired.'));
    } elseif ($status == Mage_Downloadable_Model_Link_Purchased_Item::LINK_STATUS_PENDING
        || $status == Mage_Downloadable_Model_Link_Purchased_Item::LINK_STATUS_PAYMENT_REVIEW
    ) {
        $this->_getCustomerSession()->addNotice(Mage::helper('downloadable')->__('The link is not available.'));
    } else {
        $this->_getCustomerSession()->addError(
            Mage::helper('downloadable')->__('An error occurred while getting the requested content. Please contact the store owner.')
        );
    }

^{See the catch section and last else section}

Try to log the error happens there. You can use Mage::log() function for that. Use this for more details on logging.

Best Answer

Related Solutions

Product List – How to Show Downloadable Link Title and Price

Magento – Unable to Download downloadable products

Related Topic