Magento – “Undefined property: Interceptor::$invoiceService” while overriding controller in magento2

magento2

I am trying to override "Adminhtml\Order\Invoice\Save" controller, So I made changes in di.xml as below –

<preference for="Magento\Sales\Controller\Adminhtml\Order\Invoice\Save" type="Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice\Save" />

And create as save.php controller at location –
Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice\Save.php

and overide its execute function like below –

namespace Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice;

    class Save extends \Magento\Sales\Controller\Adminhtml\Order\Invoice\Save
    {

        public function execute()
        {
           /** @var \Magento\Backend\Model\View\Result\Redirect $resultRedirect */
            ====
            ....................
            ........................
            default code............
            ......................

            try {
                $invoiceData = $this->getRequest()->getParam('invoice', []);
                $invoiceItems = isset($invoiceData['items']) ? $invoiceData['items'] : [];

                /** @var \Magento\Sales\Model\Order $order */
                $order = $this->_objectManager->create('Magento\Sales\Model\Order')->load($orderId);
                if (!$order->getId()) {
                    throw new \Magento\Framework\Exception\LocalizedException(__('The order no longer exists.'));
                }

                if (!$order->canInvoice()) {
                    throw new \Magento\Framework\Exception\LocalizedException(
                        __('The order does not allow an invoice to be created.')
                    );
                }
                //====on below line its giving error========     
                $invoice = $this->invoiceService->prepareInvoice($order, $invoiceItems);

                if (!$invoice) {
                    throw new LocalizedException(__('We can\'t save the invoice right now.'));
                }

                if (!$invoice->getTotalQty()) {
                    throw new \Magento\Framework\Exception\LocalizedException(
                        __('You can\'t create an invoice without products.')
                    );
                }
                $this->registry->register('current_invoice', $invoice);
                if (!empty($data['capture_case'])) {
                    $invoice->setRequestedCaptureCase($data['capture_case']);
                }

                if (!empty($data['comment_text'])) {
                    $invoice->addComment(
                        $data['comment_text'],
                        isset($data['comment_customer_notify']),
                        isset($data['is_visible_on_front'])
                    );

                    $invoice->setCustomerNote($data['comment_text']);
                    $invoice->setCustomerNoteNotify(isset($data['comment_customer_notify']));
                }

                $invoice->register();

                $invoice->getOrder()->setCustomerNoteNotify(!empty($data['send_email']));
                $invoice->getOrder()->setIsInProcess(true);

                $transactionSave = $this->_objectManager->create(
                    'Magento\Framework\DB\Transaction'
                )->addObject(
                    $invoice
                )->addObject(
                    $invoice->getOrder()
                );
                $shipment = false;
                if (!empty($data['do_shipment']) || (int)$invoice->getOrder()->getForcedShipmentWithInvoice()) {
                    $shipment = $this->_prepareShipment($invoice);
                    if ($shipment) {
                        $transactionSave->addObject($shipment);
                    }
                }
                $transactionSave->save();
                //=================
                //===My custom code========
                //=================
                //....................
                ........................
                default code............
                ......................

                return $resultRedirect->setPath('sales/order/view', ['order_id' => $orderId]);
            } catch (LocalizedException $e) {
                $this->messageManager->addError($e->getMessage());
            } catch (\Exception $e) {
                echo "<pre>"; 
                print_r($e->getMessage()); die;
                $this->messageManager->addError(__('We can\'t save the invoice right now.'));
                $this->_objectManager->get('Psr\Log\LoggerInterface')->critical($e);
            }
            return $resultRedirect->setPath('sales/*/new', ['order_id' => $orderId]);
        }
    }

On this line its giving me error –

$invoice = $this->invoiceService->prepareInvoice($order, $invoiceItems);

Error – : Notice: Undefined property: Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice\Save\Interceptor::$invoiceService in /var/www/html/git_projects/testbeat/app/code/Customcode/Productserialno/Controller/Sales/Adminhtml/Order/Invoice/Save.php on line 51

Please let me know what I am doing wrong .

Thanks

Best Answer

The scope of this variable is private. Hence you can't use this in your overriding (inherited) class. please inject Magento\Sales\Model\Service\InvoiceService class for this variable in your constructor as it is injected into the main class.

Don't forget to run upgrade and di:compile commands after DI.

Edit: try this in your class

<?php

namespace Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice;


use Magento\Backend\App\Action;
use Magento\Framework\Registry;
use Magento\Sales\Model\Order\Email\Sender\InvoiceSender;
use Magento\Sales\Model\Order\Email\Sender\ShipmentSender;
use Magento\Sales\Model\Order\ShipmentFactory;
use Magento\Sales\Model\Service\InvoiceService;

class Save extends \Magento\Sales\Controller\Adminhtml\Order\Invoice\Save
{
    /**
     * @var InvoiceService
     */
    private $invoiceService;

    public function __construct
    (
        Action\Context $context,
        Registry $registry,
        InvoiceSender $invoiceSender,
        ShipmentSender $shipmentSender,
        ShipmentFactory $shipmentFactory,
        InvoiceService $invoiceService
    )
    {
        $this->invoiceService = $invoiceService;
        parent::__construct($context, $registry, $invoiceSender, $shipmentSender, $shipmentFactory, $invoiceService);
    }

    /**
     * Save invoice
     * We can save only new invoice. Existing invoices are not editable
     *
     * @return \Magento\Framework\Controller\ResultInterface
     *
     * @SuppressWarnings(PHPMD.CyclomaticComplexity)
     * @SuppressWarnings(PHPMD.NPathComplexity)
     * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
     */
    public function execute()
    {
        ..........................
        .......All code with customization------
    }
}

=================My Code is this ===================

namespace Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice;

class Save extends \Magento\Sales\Controller\Adminhtml\Order\Invoice\Save
{
    /**
     * @var InvoiceService
     */
    private $invoiceService;

    public function __construct(
        \Magento\Backend\App\Action $context,
        Registry $registry,
        InvoiceSender $invoiceSender,
        ShipmentSender $shipmentSender,
        ShipmentFactory $shipmentFactory,
        InvoiceService $invoiceService
    ) {
        parent::__construct($context, $registry, $invoiceSender, $shipmentSender, $shipmentFactory, $invoiceService);
    }

  public function execute() { 
..........................
.......All code with customization------
}

}

Plz check because my code still giving same error. Recoverable Error: Argument 1 passed to Customcode\Productserialno\Controller\Sales\Adminhtml\Order\Invoice\Save::__construct() must be an instance of Magento\Backend\App\Action,

Plz let me know what I m doing wrong.

Related Solutions

Magento2 Error – Interceptor Error in Controller

The translation function __() is defined in app/functions.php and is not a part of $this. You should call it directly, without $this, as follows:

public function execute()
{
   ....

   $rootCategory = $this->catalogCategoryFactory->create()
      ->load($rootCategoryId)
      ->setName(__('Sale'))   //no more error
      ->setMetaTitle(__('Sale'))
      ->setMetaDescription(__('Sale'))
      ->setMetaKeywords(__('Sale'));
       ....
}

Magento2 Controllers – Notice: Undefined Property Interceptor::$inlineTranslation

You need to add \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation, in your Controller or remove $this->inlineTranslation->suspend(); from Controller file.

Just copy constructor method from : \Magento\Contact\Controller\Index\Post and add your new : \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation,.

Also, add :

/**
 * @var \Magento\Framework\Translate\Inline\StateInterface
 */
protected $inlineTranslation;

In your file before constructor method.

Your code should be like this:

<?php

namespace Mycontct\Person\Controller\Magento\Contact\Index;

use Magento\Framework\App\Action\Context;
use Magento\Contact\Model\ConfigInterface;
use Magento\Contact\Model\MailInterface;
use Psr\Log\LoggerInterface;
use Magento\Framework\App\Request\DataPersistorInterface;
use Magento\Framework\App\ObjectManager;
use \Magento\Framework\Translate\Inline\StateInterface;
class Post extends \Magento\Contact\Controller\Index\Post
{
    /**
     * @var DataPersistorInterface
     */
    private $dataPersistor;

    /**
     * @var Context
     */
    private $context;

    /**
     * @var MailInterface
     */
    private $mail;

    /**
     * @var LoggerInterface
     */
    private $logger;

    protected $inlineTranslation;
    public function __construct(
        Context $context,
        ConfigInterface $contactsConfig,
        MailInterface $mail,
        DataPersistorInterface $dataPersistor,
        LoggerInterface $logger = null,
        \Magento\Framework\Translate\Inline\StateInterface $inlineTranslation
    ) {
        parent::__construct($context, $contactsConfig,$mail,$dataPersistor);
        $this->inlineTranslation = $inlineTranslation;
        $this->context = $context;
        $this->mail = $mail;
        $this->dataPersistor = $dataPersistor;
        $this->logger = $logger ?: ObjectManager::getInstance()->get(LoggerInterface::class);
    }
    public function execute()
    {

        $post = $this->getRequest()->getPostValue();

        if (!$post) {
            $this->_redirect('*/*/');
            return;
        }

        $this->inlineTranslation->suspend();
        try {
            $postObject = new \Magento\Framework\DataObject();
            $postObject->setData($post);

            $error = false;

            if (!\Zend_Validate::is(trim($post['name']), 'NotEmpty')) {
                $error = true;
            }
            if (!\Zend_Validate::is(trim($post['comment']), 'NotEmpty')) {
                $error = true;
            }
            if (!\Zend_Validate::is(trim($post['email']), 'EmailAddress')) {
                $error = true;
            }
            if (\Zend_Validate::is(trim($post['hideit']), 'NotEmpty')) {
                $error = true;
            }
            if ($error) {
                throw new \Exception();
            }

            $storeScope = \Magento\Store\Model\ScopeInterface::SCOPE_STORE;
            $transport = $this->_transportBuilder
                ->setTemplateIdentifier($this->scopeConfig->getValue(self::XML_PATH_EMAIL_TEMPLATE, $storeScope))
                ->setTemplateOptions(
                    [
                        'area' => \Magento\Backend\App\Area\FrontNameResolver::AREA_CODE,
                        'store' => \Magento\Store\Model\Store::DEFAULT_STORE_ID,
                    ]
                )
                ->setTemplateVars(['data' => $postObject])
                ->setFrom($this->scopeConfig->getValue(self::XML_PATH_EMAIL_SENDER, $storeScope))
                ->addTo($this->scopeConfig->getValue(self::XML_PATH_EMAIL_RECIPIENT, $storeScope))
                ->setReplyTo($post['email'])
                ->getTransport();

            $transport->sendMessage();
            $this->inlineTranslation->resume();

            $message = __('Thanks for contacting us with your comments and questions. We\'ll respond to you very soon.');

            $this->getDataPersistor()->clear('contact_us');
            echo $message;
            //$this->_redirect('contact/index');
            return;
        } catch (\Exception $e) {
            $this->inlineTranslation->resume();
            $message =
                __('We can\'t process your request right now. Sorry, that\'s all we know.');

            $this->getDataPersistor()->set('contact_us', $post);
            //$this->_redirect('contact/index');
            echo $message;
            return;
        }
    }

    private function getDataPersistor()
    {
        if ($this->dataPersistor === null) {
            $this->dataPersistor = ObjectManager::getInstance()
                ->get(DataPersistorInterface::class);
        }

        return $this->dataPersistor;
    }
}

Best Answer

Related Solutions

Magento2 Error – Interceptor Error in Controller

Magento2 Controllers – Notice: Undefined Property Interceptor::$inlineTranslation

Related Topic