Debian – NcFTP batch uploading

A common problem I have had with Windows boxes and FTP access, is that the local account I set up to log in via FTP on the target box does not have the "do not expire" checkbox checked. So basically it has expired the FTP account password, and wants it to be changed - but that can only be done manually, not through FTP.

That is the default state for new accounts created on the system and it must be changed manually (even the command line option /noexpire does not work on MS Server 2003 and below).

That might be your problem. To fix it, someone with admin access on the FTP target server has to login and check the "do not expire" checkbox for your FTP login account.

Ron

I don't understand what particular problem you are stuck on. Your description is really unclear. So I'll give some general advice on simplifying the script; if it's not enough to solve your problem, try to come up with a clearer explanation.

I'm pretty sure this script is much more complicated than it needs to be. Spending a few minutes browsing the documentation of a command to see if one of its options could help you can save hours of debugging. Spending a few minutes thinking about the general structure of the script can save hours of debugging.

Here are several ways in which you could have made your script simpler.

• All variable substitutions should be inside double quotes, i.e., always write "$foo" and not just $foo. You've done it sometimes, but not systematically. Always use double quotes unless you know why you do not want them in a particular case.

• Here's a simpler way of writing your help function; it's called a “here document”.

  function help()
  {
      cat <<EOF
  This script is responsible for simply recursively searching patterns
  given in [INPUT FILE] in [PATH]. If pattern is not found then it is
  written to [OPTIONAL OUTPUT FILE]. If [OPTIONAL OUTPUT FILE] is not
  given the default [OUTPUT FILE] name is: out
  Usage: $0 [INPUT FILE] [PATH TO DIRECTORY] [OPTIONAL OUTPUT FILE]
  e.g. : $0 input_file /var/www/html/ output_file
  or   : $0 help -> this help
  EOF
  }
  

• Give your script a non-zero exit code to indicate failure:

  if [ $# -lt 2 ]; then help; exit 2; fi
  if [ ! -e "$in" ]; then echo "Input file: $1 does not exist"; exit 2; fi
  if [ ! -d "$path" ]; then  echo "Path: $path does not exist"; exit 2; fi
  

• Modifying the input file in is surprising, and you can combine the whitespace-only line removal with the multiple sed expressions that add a backslash before some characters.

  <"$in" sed -e '/^ *$/d' -e 's,[-\\".],\\&,g' > "$tmp"
  

  However the quoting you perform here is strange. Why are you quoting - and ", which are not special to grep, but not * and [ which are special? What is the syntax of the patterns supposed to be?

  If you meant the patterns to be literal strings to look for, all this work is unnecessary (except for removing whitespace-only lines): call grep -F.

• In the part that reads the lines from $tmp, you don't need the counter variable, you can just append to the array. You also need to pass the -r argument to the read built-in, so that it doesn't strip some backslashes.

  while read -r line; do
      linesTable+=("$line")
  done <"$tmp"
  

• In the loop over the patterns, you store the output of grep in a variable, but all you're doing is testing if grep found a match. It would be a lot easier (and faster) to use the return code of grep for that. (I've also removed what is presumably debugging output from the loop; you don't need tee to append to a file, just use the redirection operator >>.)

  for line in "${linesTable[@]}"; do
      grep -q -r -- "$line" "$path"
      if [ $? -ne 0 ]; then echo "$line" >>"$tmp"; fi
  done
  

• You don't need to free memory at the end of the script. If this was really a function that was part of a bigger script, you should declare them with the local builtin.

Here's a restructured version of the part of your script after the command line parsing. I've incorporated the local changes outlined above and used functions to make the structure clearer. Note that the clearer structure means I don't need to use a temporary file. I don't know if the resulting script does what you want, since you don't explain precisely what you want.

function extract_patterns () {
    <"$in" sed -e '/^ *$/d' -e 's,[-\\".],\\&,g'
}

function report_missing_patterns () {
  local pattern
  for pattern in "$@"; do
    grep -q -r -- "$pattern" "$path"
    if [ $? -ne 0 ]; then printf "%s\n" "$pattern"; fi
  done
}

process_patterns () {
  local patterns line
  patterns=()
  while read -r line; do
      patterns+=("$line")
  done
  report_missing_patterns "${patterns[@]}" | sort -u >"$out"
}

extract_patterns | process_patterns