Php – Can i write html on one line only in the php code

htmlPHP

i need to embed a html 301 redirect in my php code and i wanted to save chars in my html.
Can i write HTML on one line since it is parsed? Is there anything against this practice?

?>
<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"><html><head><title>301 Moved Permanently</title></head><body><h1>Moved Permanently</h1><p>The document has moved <a href="<?php echo $location ?>">here</a>.</p></body></html>
<?

thank you

Best Answer

Your single-line HTML snippet will work fine. Improperly written browsers could conceivably choke on one-liners that exceed ridiculous maximum lengths, but in practice something like your snippet should not pose any problem.

Of course, since you work in PHP anyway, my preferred way of handling redirections would be something like:

<?php
header("HTTP/1.1 301 Moved Permanently");
header("Location: http://www.New-Website.com");
?>

But that's up to you. :-)

General

Indents are 4 spaces.
Indent new levels
Comments are < ~80 chars from the indent level. If I'm in two levels (8 spaces) that means the cursor stop will be around 88 characters.
Use multi-line comments. I prefer the look, however this is a subjective point.
Comment now rather then later when you have no idea what's going on.
Allman style braces. It's cleaner and is more readable. Subjective.

JavaScript

Use a library. jQuery in particular is very good. It eliminates all cross browser headaches.
Understand that ID's are for particular elements, classes are for styles. ID's shouldn't be used more then once per page and they will have particular hooks attached to them. Use classes for things like navigation.
Out source into methods. It's tempting to put all the code into the bind call, however putting it in it's own function will increase the flexibility of your code.
Use functions instead of evals. That means setTimeout(function(){ /* Do something */ }, 1000); instead of setTimeout('doSomething', 1000);
Use local variables with var.

HTML

Semantic markup. Use appropriate tags. Don't put <br />'s in there to add space, adjust margins and CSS rules.
All tags are lowercase.
All tags should end with a closing tag or be self closing.
Make use of classes for layout that is similar. Have a couple of predefined classes like hide, clear, error, etc.
Everything (scripts included) should go in <head>. Worry about optimizing (moving stuff around) when it presents a problem.
External stylesheets and JavaScript source is a must unless it is page specific.

PHP

Frameworks are good, I recommend CodeIgniter.
If you don't want to use a framework, try to use the latest version of PHP possible. (That means 5.3).
Use includes to your advantage.
Clear injections or use prepared statements.

Perform if checks on preconceived fail-secure values.

$logged_in = false;
if(check_user($user))
{
     $logged_in = true;
     $user = load_user($_SESSION);
}

Know the difference between single and double quotes. Use single quotes when possible.
Don't echo HTML.

Php – Is MVC now the only way to write PHP

No.

What pattern you use always depends on the task your program/script has to perform. Just yesterday I had to solve this:

show the mtime of two files
show number of temp files in a folder
allow deleting all temp files with one click
web interface

I know one could argue that a nice reusable MVC solution would be cleaner, but I choose a 20 lines of sequential code. Why? It is fast. It is small. And every minute I spend on this is a minute I can not use on my main project.

(let the hate begin!)

Best Answer

Related Solutions

Javascript – PHP, HTML, Javascript and writing good practices

General

JavaScript

HTML

PHP

Php – Is MVC now the only way to write PHP

Related Topic