Well, in a REST interface, following HTTP where ever possible, I would return a 201 and an URI in the Location header field to the newly created Resource. Here is what Status Code Definitions says:
10.2.2 201 Created
The request has been fulfilled and resulted in a new resource being
created. The newly created resource can be referenced by the URI(s)
returned in the entity of the response, with the most specific URI for
the resource given by a Location header field. The response SHOULD
include an entity containing a list of resource characteristics and
location(s) from which the user or user agent can choose the one most
appropriate. The entity format is specified by the media type given in
the Content-Type header field. The origin server MUST create the
resource before returning the 201 status code. If the action cannot be
carried out immediately, the server SHOULD respond with 202 (Accepted)
response instead.
If something went wrong, I would argue you shouldn't return -1
as others have said, but simply a Client or Server Error Code (4xx or 5xx). For example, if a user is not allowed to create some new resource, you would simply return a "401 Unauthorized", nothing more and nothing less.
When in doubt, consult the documentation. Reviewing the W3C definitions for HTTP Status codes, gives us this:
200 OK - The request has succeeded. The information returned with the response is dependent on the method used in the request.
404 Not Found - The server has not found anything matching the Request-URI.
In the context of your API, it very much depends on how queries are created and how objects are retrieved. But, my interpretation has always been that:
- If I ask for a particular object, and it exists return
200
code, if it doesn't exist return the correct 404
code.
- But, if I ask for a set of objects that match a query, a null set is a valid response and I want that returned with a
200
code. The rationale for this is that the query was valid, it succeeded and the query returned nothing.
So in this case you are correct, the service isn't searching for "a specific thing" it is requesting a particular thing, if that thing isn't found say that clearly.
I think Wikipedia puts it best:
200 OK - ... The actual response will depend on the request method used. In a GET request, the response will contain an entity corresponding to the requested resource.
404 Not Found - The requested resource could not be found but may be available again in the future. Subsequent requests by the client are permissible.
Seems pretty clear to me.
Regarding the example requests
/GoalTree/GetByDate?versionDate=...
/GoalTree/GetById?versionId=...
For the format, you said, you always return the nearest revision to that date. It will never not return an object, so it should always be returning 200 OK
. Even if this were able to take a date range, and the logic were to return all objects within that timeframe returning 200 OK - 0 Results is ok, as that is what the request was for - the set of things that met that criteria.
However, the latter is different as you are asking for a specific object, presumably unique, with that identity. Returning 200 OK
in this case is wrong as the requested resource doesn't exist and is not found.
Regarding choosing status codes
- 2xx codes Tell a User Agent (UA) that it did the right thing, the request worked. It can keep doing this in the future.
- 3xx codes Tell a UA what you asked probably used to work, but that thing is now elsewhere. In future the UA might consider just going to the redirect.
- 4xx codes Tell a UA it did something wrong, the request it constructed isn't proper and shouldn't try it again, without at least some modification.
- 5xx codes Tell a UA the server is broken somehow. But hey that query could work in the future, so there is no reason not to try it again. (except for 501, which is more of a 400 issue).
You mentioned in a comment using a 5xx code, but your system is working. It was asked a query that doesn't work and needs to communicate that to the UA. No matter how you slice it, this is 4xx territory.
Consider an alien querying our solar system
Alien: Computer, please tell me all planets that humans inhabit.
Computer: 1 result found. Earth
Alien: Computer, please tell me about Earth.
Computer: Earth - Mostly Harmless.
Alien: Computer, please tell me about all planets humans inhabit, outside the asteroid belt.
Computer: 0 results found.
Alien: Computer, please destroy Earth.
Computer: 200 OK.
Alien: Computer, please tell me about Earth.
Computer: 404 - Not Found
Alien: Computer, please tell me all planets that humans inhabit.
Computer: 0 results found.
Alien: Victory for the mighty Irken Empire!
Best Answer
If the user 52 doesn't exist, return HTTP 404. Returning HTTP 200 is misleading.
Think about it from the point of view of the client. Would the following dialog make sense to you?
The case where you could use HTTP 200 with
null
is when you don't have information about a part of the entry being requested. Imagine a case where the users have a purchase history, unless they registered very recently and haven't been approved yet (and cannot order anything). For an ordinary, approved user, the response will be:Instead, the user 52 doesn't have a purchase history:
This is semantically different from an empty sequence.
"purchase-history": []
means that the user has a history, but haven't purchased anything yet. Anull
has a very different meaning.