Android: intent passed to an activity by notifications……i don’t get the right extras in the intent

androidandroid-intentflagsnotifications

Hi i'm facing this problem. I have an application with 2 activities:
-Activity A (Main activity) showing a list of cars
-If you click on an item list the Activity B is started showing car's details.

From within activity B you can download info related to that car, a service C in charge of the download is started and a notification is added to the notification bar. If you click the notification you are supposed to see Activity B showing details related to that specific car.

My problem is the following: activity B gets an intent with this extra: carID
So in onCreate it reads this extra and ask the db for that specific car details.
When i call Activity B from activity A everything works fine. But when i call activity B from the notification bar it doesn't. It always get details about the first car i chose.
So for example, i download Ferrari details, and then Lamborghini details….

In my notification i will see 2 notifications, but both of them open activity B showing Ferrari details.

This is how i create the notifications inside the Service C:

int icon = icona;  
CharSequence tickerText = message;              
long when = System.currentTimeMillis();         
Context context = getApplicationContext();      
CharSequence contentTitle = message;  
CharSequence contentText = appName;      
Intent notificationIntent;
notificationIntent = new Intent(this, ActivityB.class);
notificationIntent.putExtra("carId", carId);
PendingIntent contentIntent = PendingIntent.getActivity(this, 0, notificationIntent,     PendingIntent.FLAG_UPDATE_CURRENT);
Notification notification = new Notification(icon, tickerText, when);
notification.setLatestEventInfo(context, contentTitle, contentText, contentIntent);
String ns = Context.NOTIFICATION_SERVICE;
NotificationManager mNotificationManager = (NotificationManager) getSystemService(ns);
mNotificationManager.notify(NOT_ID, notification);

and this is how i receive the intent in Activity B:

Intent myIntent = getIntent(); 
appId = myIntent.getIntExtra("carId", 0);

At the beginning i didn't receive any intent at all from the notification…..then i added PendingIntent.FLAG_UPDATE_CURRENT as you can see above and i get it, but it always the first one. I have verified, and i add the correct carId to each intente but i get another one instead……and each time a open the notification this log message appears:

startActivity called from non-Activity context; forcing Intent.FLAG_ACTIVITY_NEW_TASK for: Intent { cmp=market.finestraprincipale/.ApplicationActivity bnds=[0,101][320,165] (has extras) }

Can someone help me pls….

Best Answer

(Original answer revised, see edit history for it)

I'm not actually sure, which part of your system is malfunctioning so I post my test code here, which I tested to work correctly. First there is MyService, then TestActivity which displays the car details in DetailsActivity:

CarService.java

public class CarService extends IntentService
{
    public CarService()
    {
        super("CarService");
    }

    protected void onHandleIntent(Intent intent)
    {
        Bundle extras = intent.getExtras();
        if (extras == null)
        {
            Log.e("CarService", "Service onHandleIntent null extras");
            return;
        }

        int carId = extras.getInt("carId");
        String carName = extras.getString("name");
        Log.i("CarService", "Service onHandleIntent car = " + carName + " with ID = " + Integer.toString(carId));

        Intent notificationIntent;
        notificationIntent = new Intent(this, DetailsActivity.class);
        notificationIntent.putExtra("carId", carId);
        notificationIntent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);

        PendingIntent pending = PendingIntent.getActivity(this, carId, notificationIntent, PendingIntent.FLAG_UPDATE_CURRENT);

        Notification notif = new Notification(R.drawable.icon, carName, System.currentTimeMillis());
        notif.flags |= Notification.FLAG_AUTO_CANCEL;
        notif.setLatestEventInfo(getApplicationContext(), carName, "Car Details", pending);

        NotificationManager mNotificationManager = (NotificationManager) getSystemService(Context.NOTIFICATION_SERVICE);
        mNotificationManager.notify(carId, notif);
    }
}

TestActivity.java (your main activity)

public class TestActivity extends Activity implements OnClickListener
{
    @Override public void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.test);

        Button btn = (Button) findViewById(R.id.launch);
        btn.setOnClickListener(this);
    }

    @Override public void onClick(View v)
    {
        startActivity(new Intent(this, DetailsActivity.class));
    }
}

test.xml (layout for TestActivity.java)

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:a="http://schemas.android.com/apk/res/android" a:id="@+id/layout_root" a:orientation="vertical" a:layout_width="fill_parent" a:layout_height="fill_parent">
    <TextView a:id="@+id/test_value"  a:text="Main..." a:layout_width="wrap_content" a:layout_height="wrap_content"/>
    <Button a:id="@+id/launch" a:text="Details" a:layout_width="100dp" a:layout_height="wrap_content"/>
</LinearLayout>

DetailsActivity.java (car details listed here + launches CarService + notifications lead back to here)

public class DetailsActivity extends Activity implements OnClickListener
{
    private String[] cars = new String[]{"Ferrari", "Lamborghini", "Lada", "Nissan", "Opel", "Bugatti"};
    private int id = 0;


    @Override public void onCreate(Bundle savedInstanceState)
    {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.details);

        Button btn = (Button) findViewById(R.id.doit);
        btn.setOnClickListener(this);

        Bundle extras = getIntent().getExtras();
        if (extras != null)
        {
            final int id = extras.getInt("carId");
            Log.i("DetailsActivity", "Car ID: " + id);
            TextView tv = (TextView) findViewById(R.id.test_value);
            tv.setText("Car ID = " + Integer.toString(id) + ", which is " + cars[id%6]); // id%6 prevents a crash with the string array when clicking test button over 6 times
        }
    }

    @Override public void onClick(View v)
    {
        Intent intent = new Intent(this, CarService.class);
        intent.putExtra("carId", id);
        intent.putExtra("name", cars[id%6]); // id%6 prevents a crash with the string array when clicking test button over 6 times
        startService(intent);
        ++id;
    }
}

details.xml (layout for TestActivity.java)

<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:a="http://schemas.android.com/apk/res/android" a:orientation="vertical" a:layout_width="fill_parent" a:layout_height="fill_parent">
    <TextView a:id="@+id/test_value" a:text="No details yet: click the button." a:layout_width="wrap_content" a:layout_height="wrap_content"/>
    <Button a:id="@+id/doit" a:text="Test" a:layout_width="100dp" a:layout_height="wrap_content"/>
</LinearLayout>

I hope all that works correctly as I did make some minor changes on the fly.

Related Solutions

Android – Sending data back to the Main Activity in Android

There are a couple of ways to achieve what you want, depending on the circumstances.

The most common scenario (which is what yours sounds like) is when a child Activity is used to get user input - such as choosing a contact from a list or entering data in a dialog box. In this case you should use startActivityForResult to launch your child Activity.

This provides a pipeline for sending data back to the main Activity using setResult. The setResult method takes an int result value and an Intent that is passed back to the calling Activity.

Intent resultIntent = new Intent();
// TODO Add extras or a data URI to this intent as appropriate.
resultIntent.putExtra("some_key", "String data"); 
setResult(Activity.RESULT_OK, resultIntent);
finish();

To access the returned data in the calling Activity override onActivityResult. The requestCode corresponds to the integer passed in in the startActivityForResult call, while the resultCode and data Intent are returned from the child Activity.

@Override
public void onActivityResult(int requestCode, int resultCode, Intent data) {
  super.onActivityResult(requestCode, resultCode, data);
  switch(requestCode) {
    case (MY_CHILD_ACTIVITY) : {
      if (resultCode == Activity.RESULT_OK) {
        // TODO Extract the data returned from the child Activity.
        String returnValue = data.getStringExtra("some_key");
      }
      break;
    } 
  }
}

Android – the simplest and most robust way to get the user’s current location on Android

Here's what I do:

First of all I check what providers are enabled. Some may be disabled on the device, some may be disabled in application manifest.
If any provider is available I start location listeners and timeout timer. It's 20 seconds in my example, may not be enough for GPS so you can enlarge it.
If I get update from location listener I use the provided value. I stop listeners and timer.
If I don't get any updates and timer elapses I have to use last known values.
I grab last known values from available providers and choose the most recent of them.

Here's how I use my class:

LocationResult locationResult = new LocationResult(){
    @Override
    public void gotLocation(Location location){
        //Got the location!
    }
};
MyLocation myLocation = new MyLocation();
myLocation.getLocation(this, locationResult);

And here's MyLocation class:

import java.util.Timer;
import java.util.TimerTask;
import android.content.Context;
import android.location.Location;
import android.location.LocationListener;
import android.location.LocationManager;
import android.os.Bundle;

public class MyLocation {
    Timer timer1;
    LocationManager lm;
    LocationResult locationResult;
    boolean gps_enabled=false;
    boolean network_enabled=false;

    public boolean getLocation(Context context, LocationResult result)
    {
        //I use LocationResult callback class to pass location value from MyLocation to user code.
        locationResult=result;
        if(lm==null)
            lm = (LocationManager) context.getSystemService(Context.LOCATION_SERVICE);

        //exceptions will be thrown if provider is not permitted.
        try{gps_enabled=lm.isProviderEnabled(LocationManager.GPS_PROVIDER);}catch(Exception ex){}
        try{network_enabled=lm.isProviderEnabled(LocationManager.NETWORK_PROVIDER);}catch(Exception ex){}

        //don't start listeners if no provider is enabled
        if(!gps_enabled && !network_enabled)
            return false;

        if(gps_enabled)
            lm.requestLocationUpdates(LocationManager.GPS_PROVIDER, 0, 0, locationListenerGps);
        if(network_enabled)
            lm.requestLocationUpdates(LocationManager.NETWORK_PROVIDER, 0, 0, locationListenerNetwork);
        timer1=new Timer();
        timer1.schedule(new GetLastLocation(), 20000);
        return true;
    }

    LocationListener locationListenerGps = new LocationListener() {
        public void onLocationChanged(Location location) {
            timer1.cancel();
            locationResult.gotLocation(location);
            lm.removeUpdates(this);
            lm.removeUpdates(locationListenerNetwork);
        }
        public void onProviderDisabled(String provider) {}
        public void onProviderEnabled(String provider) {}
        public void onStatusChanged(String provider, int status, Bundle extras) {}
    };

    LocationListener locationListenerNetwork = new LocationListener() {
        public void onLocationChanged(Location location) {
            timer1.cancel();
            locationResult.gotLocation(location);
            lm.removeUpdates(this);
            lm.removeUpdates(locationListenerGps);
        }
        public void onProviderDisabled(String provider) {}
        public void onProviderEnabled(String provider) {}
        public void onStatusChanged(String provider, int status, Bundle extras) {}
    };

    class GetLastLocation extends TimerTask {
        @Override
        public void run() {
             lm.removeUpdates(locationListenerGps);
             lm.removeUpdates(locationListenerNetwork);

             Location net_loc=null, gps_loc=null;
             if(gps_enabled)
                 gps_loc=lm.getLastKnownLocation(LocationManager.GPS_PROVIDER);
             if(network_enabled)
                 net_loc=lm.getLastKnownLocation(LocationManager.NETWORK_PROVIDER);

             //if there are both values use the latest one
             if(gps_loc!=null && net_loc!=null){
                 if(gps_loc.getTime()>net_loc.getTime())
                     locationResult.gotLocation(gps_loc);
                 else
                     locationResult.gotLocation(net_loc);
                 return;
             }

             if(gps_loc!=null){
                 locationResult.gotLocation(gps_loc);
                 return;
             }
             if(net_loc!=null){
                 locationResult.gotLocation(net_loc);
                 return;
             }
             locationResult.gotLocation(null);
        }
    }

    public static abstract class LocationResult{
        public abstract void gotLocation(Location location);
    }
}

Somebody may also want to modify my logic. For example if you get update from Network provider don't stop listeners but continue waiting. GPS gives more accurate data so it's worth waiting for it. If timer elapses and you've got update from Network but not from GPS then you can use value provided from Network.

One more approach is to use LocationClient http://developer.android.com/training/location/retrieve-current.html. But it requires Google Play Services apk to be installed on user device.

Best Answer

Related Solutions

Android – Sending data back to the Main Activity in Android

Android – the simplest and most robust way to get the user’s current location on Android

Related Topic