C++ – Accessing elements of OpenCV CV_8UC1 cv::Mat

copencv

I have a cv::Mat of type CV_8UC1 (8-bit single channel image) and I would like to access elements using the at<> operator as follows: image.at<char>(row, column). However, when casting to int: (int) image.at<char>(row, column), some values become negative, e.g., 255 becomes -1.

This might be a stupid question, but I can't tell why this happens and what would be a better way to convert the entries to int.

Thanks in advance!

Best Answer

You have to specify that the elements are unsigned char, between 0 and 255 , otherwise they will be char (signed), from -128 to 127. The casting will be this way:

(int) image.at<uchar>(row,column);

Related Solutions

C++ – How to convert CV_8UC1 to normal int type

From the OpenCV Reference Manual:

CV_8UC1 – unsigned 8-bit single-channel data; can be used for grayscale image or binary image – mask.

So it's just single channel 8 bit grey scale with values 0..255.

C++ – Why is the program slow when looping over exactly 8192 elements

The difference is caused by the same super-alignment issue from the following related questions:

But that's only because there's one other problem with the code.

Starting from the original loop:

for(i=1;i<SIZE-1;i++) 
    for(j=1;j<SIZE-1;j++) {
        res[j][i]=0;
        for(k=-1;k<2;k++) 
            for(l=-1;l<2;l++) 
                res[j][i] += img[j+l][i+k];
        res[j][i] /= 9;
}

First notice that the two inner loops are trivial. They can be unrolled as follows:

for(i=1;i<SIZE-1;i++) {
    for(j=1;j<SIZE-1;j++) {
        res[j][i]=0;
        res[j][i] += img[j-1][i-1];
        res[j][i] += img[j  ][i-1];
        res[j][i] += img[j+1][i-1];
        res[j][i] += img[j-1][i  ];
        res[j][i] += img[j  ][i  ];
        res[j][i] += img[j+1][i  ];
        res[j][i] += img[j-1][i+1];
        res[j][i] += img[j  ][i+1];
        res[j][i] += img[j+1][i+1];
        res[j][i] /= 9;
    }
}

So that leaves the two outer-loops that we're interested in.

Now we can see the problem is the same in this question: Why does the order of the loops affect performance when iterating over a 2D array?

You are iterating the matrix column-wise instead of row-wise.

To solve this problem, you should interchange the two loops.

for(j=1;j<SIZE-1;j++) {
    for(i=1;i<SIZE-1;i++) {
        res[j][i]=0;
        res[j][i] += img[j-1][i-1];
        res[j][i] += img[j  ][i-1];
        res[j][i] += img[j+1][i-1];
        res[j][i] += img[j-1][i  ];
        res[j][i] += img[j  ][i  ];
        res[j][i] += img[j+1][i  ];
        res[j][i] += img[j-1][i+1];
        res[j][i] += img[j  ][i+1];
        res[j][i] += img[j+1][i+1];
        res[j][i] /= 9;
    }
}

This eliminates all the non-sequential access completely so you no longer get random slow-downs on large powers-of-two.

Core i7 920 @ 3.5 GHz

Original code:

8191: 1.499 seconds
8192: 2.122 seconds
8193: 1.582 seconds

Interchanged Outer-Loops:

8191: 0.376 seconds
8192: 0.357 seconds
8193: 0.351 seconds

Best Answer

Related Solutions

C++ – How to convert CV_8UC1 to normal int type

C++ – Why is the program slow when looping over exactly 8192 elements

Related Topic