ItemUpdating called twice after ItemAdded in event receiver

sharepoint-2010

I've created an event receiver to handle the ItemAdded and ItemUpdating events on a document library in SharePoint 2010.

I've encountered a problem where when I add a document to the library (e.g. by saving it back from Word) the ItemAdded method is correctly called however this is then followed by two calls to ItemUpdating. I have removed all code from my handlers to ensure that it's not something I'm doing inside that is causing the problem. They literally look like:

public override void ItemUpdating(SPItemEventProperties properties)
{
}

public override void ItemAdded(SPItemEventProperties properties)
{
}

Does anyone have a solution to this issue?

Here is my elements.xml file for the event receiver:

<Elements xmlns="http://schemas.microsoft.com/sharepoint/">
  <Receivers ListTemplateId="101">
      <Receiver>
        <Name>DocumentsEventReceiverItemUpdating</Name>
        <Type>ItemUpdating</Type>
        <Assembly>$SharePoint.Project.AssemblyFullName$</Assembly>
        <Class>My.Namespace.DocumentsEventReceiver</Class>
        <SequenceNumber>10000</SequenceNumber>
        <Synchronization>Synchronous</Synchronization>
      </Receiver>
      <Receiver>
        <Name>DocumentsEventReceiverItemAdded</Name>
        <Type>ItemAdded</Type>
        <Assembly>$SharePoint.Project.AssemblyFullName$</Assembly>
        <Class>My.Namespace.DocumentsEventReceiver</Class>
        <SequenceNumber>10000</SequenceNumber>
        <Synchronization>Synchronous</Synchronization>
      </Receiver>
  </Receivers>
</Elements>

Best Answer

Problem is that In Document library event handlers during Item Updating also checking that Document is it in Check In mode or Check Out. That's why it is called twice.

You should put your code in

 public override void ItemUpdating(SPItemEventProperties properties)
  {  
    base.ItemUpdating(properties);
    if (properties.AfterProperties["vti_sourcecontrolcheckedoutby"] == null && properties.BeforeProperties["vti_sourcecontrolcheckedoutby"] != null)
     {
       //do stuff
     }
  }

For further details Here is good article for describe whole situation of the Document's Events.

Related Solutions

SharePoint 2010 Rename Document on Upload Fails in Explorer View

I have found that using a Visual Studio workflow allows me the most flexibility to do this. A SharePoint Designer Workflow would be simpler, but would be harder to deploy to different sites and libraries.

After reading some good articles including this and this I have come up with this code which seems to work. It starts a workflow and waits until the document is not in a LockState and then processes the filename.

The workflow looks like this:

Workflow image

And here is the code behind:

namespace ControlledDocuments.RenameWorkflow
{
    public sealed partial class RenameWorkflow : SequentialWorkflowActivity
    {
        public RenameWorkflow()
        {
            InitializeComponent();
        }

        public Guid workflowId = default(System.Guid);
        public SPWorkflowActivationProperties workflowProperties = new SPWorkflowActivationProperties();

        Boolean continueWaiting = true;


        private void onWorkflowActivated1_Invoked(object sender, ExternalDataEventArgs e)
        {
            CheckFileStatus();
        }

        private void whileActivity(object sender, ConditionalEventArgs e)
        {
            e.Result = continueWaiting;
        }

        private void onWorkflowItemChanged(object sender, ExternalDataEventArgs e)
        {
            CheckFileStatus();
        }

        private void CheckFileStatus()
        {
            if (workflowProperties.Item.File.LockType == SPFile.SPLockType.None)
            {
                continueWaiting = false;
            }
        }

        private void renameFile(object sender, EventArgs e)
        {
            try
            {
                SPListItem currentItem = workflowProperties.Item;

                if (currentItem["_dlc_DocId"] != null)
                {
                    string docId = currentItem["_dlc_DocId"].ToString();
                    if (!currentItem["BaseName"].ToString().StartsWith(docId))
                    {
                        currentItem["BaseName"] = docId + currentItem["BaseName"];
                        currentItem.SystemUpdate();
                    }
                }
            }
            catch (Exception ex)
            {
                //Should do something useful here
            }
        }

    }
}

Hope this helps someone else if they have the same problem.

Convert SharePoint 2010 Solution to 2013 and Visual Studio 2012

I was able to get my solution upgraded from a 2010 project to 2013 using the following. Note that this will update your solution to use the new 2013 API. It is possible to update just the project file but still run in 2010 mode.

First edit your .csproj file (for c#).

Modify the target framework to this: <TargetFrameworkVersion>v4.5</TargetFrameworkVersion>

Add this a node for the office version, I put mine directly below the TargetFrameworkVersion tag <TargetOfficeVersion>15.0</TargetOfficeVersion>

Update references

Reload the project and update your referenced assemblies. If you haven't specified a specific version they should already be referencing the v15 (SharePoint 2013) assemblies.

Do a find replace for 14.0.0.0 to 15.0.0.0. This updates any references on your pages, layouts, and master pages to the v15 assemblies.

Change calls

Change any calls to SPUtility.GetGenericSetupPath() to SPUtility.GetVersionedGenericSetupPath()

Check each file to do a check for any hive references. You'll need to add a /15/ to these. EG: _layouts/ to _layouts/15/

Open the package "folder" in visual studio then update the properties for that package to use version 15.

Clean up

Finally do a compile clean up any missed items. Deploy your solution and make sure to test thoroughly.