Java – Utilising both a mouse listener and key listener in Java

focusjavakeylistenermouselistenerswing

I have a program which moves a an object to the left or to the right.
I want to utilise it so that it works with both a mouse listener and a key listener. With both the left arrow key and a left mouse click carrying out the same option. And vice versa for the right mouse key or arrow key.
My code currently looks a bit like this, I've cut out some unnecessary parts.

public class TetrisApplet extends JApplet implements MouseListener, KeyListener {

public void init() {

        tetris.addMouseListener(this);
        tetris.addKeyListener(this);

public void mouseReleased(MouseEvent e) {
        if (e.getButton() == MouseEvent.BUTTON1) {
            if (x > 0 && a[x - 1][y] == 0) {
                shape.move(-20, 0);
                x--;
            }
        }
        if (e.getButton() == MouseEvent.BUTTON3) {
            if (x < 9 && a[x + 1][y] == 0) {
                shape.move(+20, 0);
                x++;
            }
        }

    }

    public void keyPressed(KeyEvent e) {
        int keyCode = e.getKeyCode();
        switch (keyCode) {
            case KeyEvent.VK_LEFT:
                if (x > 0 && a[x - 1][y] == 0) {
                    shape.move(-20, 0);
                    x--;
                }
                break;
            case KeyEvent.VK_RIGHT:
                if (x < 9 && a[x + 1][y] == 0) {
                    shape.move(+20, 0);
                    x++;
                }
                break;
        }
    }

So my question is, does anyone have an answer for why it won't work for keys? My program allows the object to be moved using mouse clicks, however pressing of the left arrow and right arrow keys does absolutely nothing. And I have no idea why it isn't working. I know it's probably something small that I'm just missing, but any help is greatly appreciated.

Best Answer

I think the problem has to do with focus. The component that has the focus get the key events instead of your tetris component (which doesn't have any way to grab the focus).

The quick fix is to add:

tetris.requestFocus();

in the init method because you want the focus to start in the correct component (?) and in the mouseReleased because you want to be able to grab the focus again.

Related Solutions

Java – What are the differences between a HashMap and a Hashtable in Java

There are several differences between HashMap and Hashtable in Java:

Hashtable is synchronized, whereas HashMap is not. This makes HashMap better for non-threaded applications, as unsynchronized Objects typically perform better than synchronized ones.
Hashtable does not allow null keys or values. HashMap allows one null key and any number of null values.
One of HashMap's subclasses is LinkedHashMap, so in the event that you'd want predictable iteration order (which is insertion order by default), you could easily swap out the HashMap for a LinkedHashMap. This wouldn't be as easy if you were using Hashtable.

Since synchronization is not an issue for you, I'd recommend HashMap. If synchronization becomes an issue, you may also look at ConcurrentHashMap.

Java inner class and static nested class

From the Java Tutorial:

Nested classes are divided into two categories: static and non-static. Nested classes that are declared static are simply called static nested classes. Non-static nested classes are called inner classes.

Static nested classes are accessed using the enclosing class name:

OuterClass.StaticNestedClass

For example, to create an object for the static nested class, use this syntax:

OuterClass.StaticNestedClass nestedObject = new OuterClass.StaticNestedClass();

Objects that are instances of an inner class exist within an instance of the outer class. Consider the following classes:

class OuterClass {
    ...
    class InnerClass {
        ...
    }
}

An instance of InnerClass can exist only within an instance of OuterClass and has direct access to the methods and fields of its enclosing instance.

To instantiate an inner class, you must first instantiate the outer class. Then, create the inner object within the outer object with this syntax:

OuterClass outerObject = new OuterClass()
OuterClass.InnerClass innerObject = outerObject.new InnerClass();

see: Java Tutorial - Nested Classes

For completeness note that there is also such a thing as an inner class without an enclosing instance:

class A {
  int t() { return 1; }
  static A a =  new A() { int t() { return 2; } };
}

Here, new A() { ... } is an inner class defined in a static context and does not have an enclosing instance.

Best Answer

Related Solutions

Java – What are the differences between a HashMap and a Hashtable in Java

Java inner class and static nested class

Related Topic