JQuery SimpleModal crashing on close in windows w/ safari

crashjqueryjquery-pluginssafarisimplemodal

I'm leveraging SimpleModal on a small thing I'm working on to open an iFrame and later close it. Says to post here if having issues so here I am.

I'm having issues with the simple modal plug-in for jquery when I go to close the popup, but only on windows with safari. It works in IE/FF/Chrome/Opera on window and works in FF/Safari on Mac, and I have tested this on multiple mac and multiple windows boxes.

after calling "$.modal.close()" and entering the close function it will reach and crash the moment it hits…
"s.d.data.hide().remove();" if I remove the .remove() statement making it "s.d.data.hide()//.remove();" it will continue on and then crash the moment it hits the end of the close function where there are 3 more lines with .remove().

s.d.container.hide();//.remove();
s.d.overlay.hide();//.remove();
s.d.iframe && s.d.iframe.hide();//.remove();

Commenting them out as I did above works alright temporarily but JS not being my strongest language I'm not sure what side effects there are by not having the remove statements in place.

Best Answer

I just had a similar Problem: Only Safari on Windows chrashes if I try to "hide()" an element with jQuery. It seems to be a problem between the Flashplayer and Safari on Windows. The Element I try to hide includes the "Uploadify-Plugin" which makes use of Flash-Content, you said you hide something including a Flex-App. Both of them make use of the Flashplayer.

Workaround: I found a little workaround which is "good-enough" for me: Just do not call hide() but fadeOut(1). The one millisecond is important: as I tried fadeOut(0) it crashed again. sigh

maybe it helps..

Related Solutions

Javascript – n “exists” function for jQuery

In JavaScript, everything is 'truthy' or 'falsy', and for numbers 0 means false, everything else true. So you could write:

if ($(selector).length)

You don't need that >0 part.

Javascript – Add table row in jQuery

The approach you suggest is not guaranteed to give you the result you're looking for - what if you had a tbody for example:

<table id="myTable">
  <tbody>
    <tr>...</tr>
    <tr>...</tr>
  </tbody>
</table>

You would end up with the following:

<table id="myTable">
  <tbody>
    <tr>...</tr>
    <tr>...</tr>
  </tbody>
  <tr>...</tr>
</table>

I would therefore recommend this approach instead:

$('#myTable tr:last').after('<tr>...</tr><tr>...</tr>');

You can include anything within the after() method as long as it's valid HTML, including multiple rows as per the example above.

Update: Revisiting this answer following recent activity with this question. eyelidlessness makes a good comment that there will always be a tbody in the DOM; this is true, but only if there is at least one row. If you have no rows, there will be no tbody unless you have specified one yourself.

DaRKoN_ suggests appending to the tbody rather than adding content after the last tr. This gets around the issue of having no rows, but still isn't bulletproof as you could theoretically have multiple tbody elements and the row would get added to each of them.

Weighing everything up, I'm not sure there is a single one-line solution that accounts for every single possible scenario. You will need to make sure the jQuery code tallies with your markup.

I think the safest solution is probably to ensure your table always includes at least one tbody in your markup, even if it has no rows. On this basis, you can use the following which will work however many rows you have (and also account for multiple tbody elements):

$('#myTable > tbody:last-child').append('<tr>...</tr><tr>...</tr>');

Best Answer

Related Solutions

Javascript – n “exists” function for jQuery

Javascript – Add table row in jQuery

Related Topic