Classic ASP App CINT failure – twitpocalypse v2

asp-classicvbscript

Due to a qty value exceeding what a VBScript INT can store, I'm getting a pretty nasty error message (actually the users are)… This is totally a case of twitpocalypse.

Since CINT() will not work in this situation, what is the best workaround?

requestqty = 40200
CInt() max = 32767

CInt(requestqty)

EDIT
CLng() seems to do the trick, any risk to the code to change all CInt() to CLng(). From what I've read below and elsehwere on the web, it seems like there is really very little reason to even use CInt(). I didn't write this particular app and don't know why one was used over the other, but would prefer to not bandaid the issue and completely fix this issue in the app so it does not happen again…

Best Answer

Aways use long instead of int in VBScript (unless you specifically want to limit the value to the int range).

There is no performance benefit for using the smaller type, and there is no storage size benefit because all variables are variants, so all simple types use the same amount of memory.

Use the CLng function instead of the CInt function.

Related Solutions

ASP/VBScript – Int() vs CInt()

Int()

The Int function returns the integer part of a specified number.

CInt()

The CInt function converts an expression to type Integer.

And the best answer comes from MSDN

CInt differs from the Fix and Int functions, which truncate, rather than round, the fractional part of a number. When the fractional part is exactly 0.5, the CInt function always rounds it to the nearest even number. For example, 0.5 rounds to 0, and 1.5 rounds to 2.

ASP Classic – Type mismatch: ‘CInt’ – Easy question

You have a couple of choices. You can be proactive by checking ahead of time whether the value is numeric using the IsNumeric function:

 If IsNumeric(trainCostStr) Then
    totalTrainCost = totalTrainCost + CInt(trainCostStr)
 Else
    ' Do something appropriate
 End If

...or you can be reactive by using error catching; in Classic ASP probably easiest to define a function and use On Error Resume Next:

Function ConvertToInt(val)
    On Error Resume Next
    ConvertToInt = CInt(val)
    If Err.Number <> 0 Then
        ConvertToInt = Empty
        Err.Clear
    End If
End Function

Or return 0 or Null or whatever suits you, then use it in your trainCost code.

Note that CInt expects an integer and will stop at the first non-digit, so "123.45" comes back as 123. Look at the other conversions, CDouble, CCur, etc.

Best Answer

Related Solutions

ASP/VBScript – Int() vs CInt()

ASP Classic – Type mismatch: ‘CInt’ – Easy question

Related Topic