Sql – Page redirecting before SQL has excuted – ASP.NET MVC

asp.net-mvcsql

I have a slightly modified AccountController that should write a row into a table upon login.

However, the page redirects before the DB action has completed and so nothing is inserted.

I've temporarily solved this by sticking in a Thread.Sleep, but I'm looking for an alternative that makes it appear seamless.

    If Not String.IsNullOrEmpty(returnUrl) Then
        Return Redirect(returnUrl)
    Else
        Dim db As New GlobalSecModelDataContext
        Dim logAdmin = New secAdminLog
        logAdmin.EmployeeNumber = userName
        logAdmin.What = "Logged in"
        logAdmin.DateLogged = DateTime.Now
        logAdmin.UserIP = Request.ServerVariables("REMOTE_ADDR")
        logAdmin.NetworkUser = Request.ServerVariables("REMOTE_USER")

        db.secAdminLogs.InsertOnSubmit(logAdmin)
        db.SubmitChanges()
        Session("LoggedInUser") = StrConv(userName, VbStrConv.ProperCase)
        Threading.Thread.Sleep(5000)
        Return Redirect("/Home")
    End If

Is there a better solution that would be quicker for the user using the system or is using Threading.Thread.Sleep(5000) the best way?

I'm finding Threading.Thread.Sleep(5000) isn't perfect as the DB transaction doesn't always complete in that time.

Any suggestions would be helpful. Thanks in advance.

Best Answer

Try wrapping your InsertOnSubmit and SubmitChanges into a transaction, and commit before the redirect. I have a lot of very similar code and don't see this issue. SubmitChanges() by default runs synchronously and will not return until the SQL has executed.

Related Solutions

Asp.net-mvc – Can an ASP.NET MVC controller return an Image

Use the base controllers File method.

public ActionResult Image(string id)
{
    var dir = Server.MapPath("/Images");
    var path = Path.Combine(dir, id + ".jpg"); //validate the path for security or use other means to generate the path.
    return base.File(path, "image/jpeg");
}

As a note, this seems to be fairly efficient. I did a test where I requested the image through the controller (http://localhost/MyController/Image/MyImage) and through the direct URL (http://localhost/Images/MyImage.jpg) and the results were:

MVC: 7.6 milliseconds per photo
Direct: 6.7 milliseconds per photo

Note: this is the average time of a request. The average was calculated by making thousands of requests on the local machine, so the totals should not include network latency or bandwidth issues.

Asp.net-mvc – Compile Views in ASP.NET MVC

From the readme word doc for RC1 (not indexed by google)

ASP.NET Compiler Post-Build Step

Currently, errors within a view file are not detected until run time. To let you detect these errors at compile time, ASP.NET MVC projects now include an MvcBuildViews property, which is disabled by default. To enable this property, open the project file and set the MvcBuildViews property to true, as shown in the following example:

<Project ToolsVersion="3.5" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
  <PropertyGroup>
    <MvcBuildViews>true</MvcBuildViews>
  </PropertyGroup>

Note Enabling this feature adds some overhead to the build time.

You can update projects that were created with previous releases of MVC to include build-time validation of views by performing the following steps:

Open the project file in a text editor.
Add the following element under the top-most <PropertyGroup> element: <MvcBuildViews>true</MvcBuildViews>
At the end of the project file, uncomment the <Target Name="AfterBuild"> element and modify it to match the following:

<Target Name="AfterBuild" Condition="'$(MvcBuildViews)'=='true'">
    <AspNetCompiler VirtualPath="temp" PhysicalPath="$(ProjectDir)\..\$(ProjectName)" />
</Target>

Related Topic